PDA

View Full Version : Unicode Fixes Patch



Dan Sully
2005-07-01, 00:16
All - this patch attempts to rip out some misguided Unicode handling
attempts, and move the encoding/decoding to where it's needed specifically,
ala iTunes plugin, rather than trying to wedge it into the general case which
just confused the issues.

I've tested thus far to the best of my ability on Linux (en_US.UTF-8), OSX &
WinXP - including across a Samba share, and with iTunes, MusicMagic (all
platforms) and MoodLogic

I was not able to test on a Linux system with en_US.ISO-8859-1 encoded tracks
on the filesystem. If you have this setup - please give it a go.

If this all works, hopefully it will resolve bugs: 1474, 1596 & 1703

Thanks.

-D
--
"They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety." - Benjamin Franklin

Dan Sully
2005-07-05, 12:33
* Dan Sully shaped the electrons to say...

> All - this patch attempts to rip out some misguided Unicode handling
> attempts, and move the encoding/decoding to where it's needed specifically,
> ala iTunes plugin, rather than trying to wedge it into the general case
> which just confused the issues.
>
> I've tested thus far to the best of my ability on Linux (en_US.UTF-8), OSX
> & WinXP - including across a Samba share, and with iTunes, MusicMagic (all
> platforms) and MoodLogic
>
> I was not able to test on a Linux system with en_US.ISO-8859-1 encoded
> tracks on the filesystem. If you have this setup - please give it a go.
>
> If this all works, hopefully it will resolve bugs: 1474, 1596 & 1703

I've not recieved any feedback on this - but I've done a bunch of testing,
and am checking it in. Please let me know immediately if there are any issues
with it.

You will need to wipe your DB for everything to be correct. I'll force this later on.

-D
--
"You can usually recover from production flaws...but you can never recover from a bad design".

mherger
2005-07-06, 00:53
> I've not recieved any feedback on this - but I've done a bunch of

Ahm... we just had a couple of weeks with excellent weather... spent much
more time outdoors... no more bad excuse.

Current test on Linux - DE - iso-8859-1

> testing,
> and am checking it in. Please let me know immediately if there are any
> issues with it.

BMF: accented characters display correctly, I can open the "Amélie
Poulain" folder, songs are correctly shown. But the top link "Home/Music
folder/Am,lie Poulain" or the top line on the player don't show the
accents (dito for Björk, your ever favourite "Ohrewörm" et al., of course)

When, on the player, I go into the song details, everything's fine again,
even the top line.

Using the file.ext format on the player would not display accented
characters in the normal browse mode, though they do in BMF.

Normal genre/album/artist browse in the web interface is ok.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

mherger
2005-07-06, 03:16
> BMF: accented characters display correctly, I can open the "Amélie
> Poulain" folder, songs are correctly shown. But the top link "Home/Music
> folder/Am,lie Poulain" or the top line on the player don't show the
> accents (dito for Björk, your ever favourite "Ohrewörm" et al., of
> course)

....and I get quite a few of the following errors:

Malformed UTF-8 character (unexpected non-continuation byte 0x6c,
immediately after start byte 0xe9) in substitution (s///) at
/home/mh/eclipse/SVN/Slim/Display/Display.pm line 55.
Malformed UTF-8 character (unexpected non-continuation byte 0x6c,
immediately after start byte 0xe9) in substitution (s///) at
/home/mh/eclipse/SVN/Slim/Display/Display.pm line 84.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

dip
2005-07-07, 00:24
Shouldn't this bug (http://bugs.slimdevices.com/show_bug.cgi?id=1743) be resolved by the Unicode Fixes Patch? It seems that it isn't fixed with the latest nightly build including the patch.

mherger
2005-07-07, 00:37
> Shouldn't this bug (http://bugs.slimdevices.com/show_bug.cgi?id=1743) be
> resolved by the Unicode Fixes Patch? It seems that it isn't fixed with
> the latest nightly build including the patch.

No, it only turned up after these changes. I opened the bug only a few
hours ago after updating my slimserver from the svn trunk.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

mherger
2005-07-07, 00:41
On Thu, 07 Jul 2005 09:37:26 +0200, Michael Herger <slim (AT) herger (DOT) net> wrote:

> No, it only turned up after these changes. I opened the bug only a few
> hours ago after updating my slimserver from the svn trunk.

Oops, sorry, wrong answer. I was referring to another bug. But the one you
mention isn't fixed neither.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

IPGuy
2005-07-07, 08:08
I am running the 7/6 evening build on WinXP and my problem with Accented characters (see: http://forums.slimdevices.com/showthread.php?t=14995) is not fixed. I assume that this is based upon the Unicode problems this patch was designed to fix. Is the patch for Linux only? I tried to open on a windowsXP machine, but got an error.

vidurapparao
2005-07-07, 08:47
Did you do a complete rescan (under Server Settings > Rescan Music
Library with the "Clear library before rescan" option checked)? The
patch in the nightlies didn't force such a rescan, so you may have to
trigger it manually and wait for the rescan to complete to see an
improvement. Please report back when you get a chance.

Thanks,
--Vidur

IPGuy
2005-07-07, 09:01
I actually uninstalled the 6.02 build, deleted the program folder, installed the 7/6 build clean, rescaned the db four times while resolving other issues.

mherger
2005-07-07, 17:00
> Shouldn't this bug (http://bugs.slimdevices.com/show_bug.cgi?id=1743) be
> resolved by the Unicode Fixes Patch? It seems that it isn't fixed with
> the latest nightly build including the patch.

Dan checked in a fix for this a few hours ago. It should be in the 07-08
nightly build. Thanks, Dan!

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

IPGuy
2005-07-07, 18:45
To Dan Sully,

Given that mherger says a fix is in the next build, do you still need to see my itunes.xml file that your referenced in the parallel thread in the beta section?

Thanks for all the quick attention to this issue, now I see how SB2 got to be such a great product!

kdf
2005-07-07, 18:57
On 7-Jul-05, at 6:45 PM, IPGuy wrote:

>
> To Dan Sully,
>
> Given that mherger says a fix is in the next build, do you still need
> to see my itunes.xml file that your referenced in the parallel thread
> in the beta section?
>

mherger was speaking only of a fix to output the 'Now playing' playlist
in a form that allows the full character set.

other accented character issues still exist.

-kdf

IPGuy
2005-07-08, 09:45
Thanks for the clarification, I will post the requested file tonight.