PDA

View Full Version : [Slim-Checkins] r3465 - in trunk/server: CPAN/TestSlim/Formats Slim/Utils



Robert Moser
2005-06-21, 12:58
dsully (AT) svn (DOT) slimdevices.com wrote:
> Author: dsully
> Date: 2005-06-20 13:42:03 -0700 (Mon, 20 Jun 2005)
> New Revision: 3465
>
> Modified:
> trunk/server/Slim/Utils/Misc.pm
> Log:
> Misc: Don't list .DS_Store files.
> Allow directories with 3 or more leading dots. (Can't find the bug).
> Modified: trunk/server/Slim/Utils/Misc.pm
> ================================================== =================
> --- trunk/server/Slim/Utils/Misc.pm 2005-06-20 20:31:34 UTC (rev 3464)
> +++ trunk/server/Slim/Utils/Misc.pm 2005-06-20 20:42:03 UTC (rev 3465)
> @@ -747,7 +914,7 @@
> for my $dir (readdir(DIR)) {
>
> # Ignore items starting with a period on non-windows machines
> - next if $dir =~ /^\./ && (Slim::Utils::OSDetect::OS() ne 'win');
> + next if $dir =~ /^\.\.?$/ && (Slim::Utils::OSDetect::OS() ne 'win');
>
> my $fullpath = catdir($dirname, $dir);
>

This should either be fixed a different way, or removed entirely, we
already have explicit checks for . and .. in %_ignoredItems. The point
to checking to see if the item starts with a . is to skip "hidden"
things in unix-like OS's.

Dan Sully
2005-06-21, 13:28
* Robert Moser shaped the electrons to say...

>This should either be fixed a different way, or removed entirely, we
>already have explicit checks for . and .. in %_ignoredItems. The point
>to checking to see if the item starts with a . is to skip "hidden"
>things in unix-like OS's.

But then we skip things like:

/bits/music/DJ Shadow/The Private Press/...Meets His Maker.flac

-D
--
"Hey, careful, man, there's a beverage here!"

kdf
2005-06-21, 13:53
Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:

> * Robert Moser shaped the electrons to say...
>
> >This should either be fixed a different way, or removed entirely, we
> >already have explicit checks for . and .. in %_ignoredItems. The point
> >to checking to see if the item starts with a . is to skip "hidden"
> >things in unix-like OS's.
>
> But then we skip things like:
>
> /bits/music/DJ Shadow/The Private Press/...Meets His Maker.flac

might the bug you were looking for on this be:
http://bugs.slimdevices.com/show_bug.cgi?id=228

its not quite the same, but perhaps close enough to have twigged the memory.

-kdf

Robert Moser
2005-06-22, 11:54
Dan Sully wrote:
> * Robert Moser shaped the electrons to say...
>
>> This should either be fixed a different way, or removed entirely, we
>> already have explicit checks for . and .. in %_ignoredItems. The
>> point to checking to see if the item starts with a . is to skip
>> "hidden" things in unix-like OS's.
>
>
> But then we skip things like:
>
> /bits/music/DJ Shadow/The Private Press/...Meets His Maker.flac
>
> -D

If that is not desired behavior, then the check should be removed
entirely, as its current state is redundant.