PDA

View Full Version : [Slim-Checkins] r3477 -branches/playlistdb-bmf/server/Slim/Player



Triode
2005-06-21, 11:42
Dan,

I've not looked at the code for this, but if it avoids calling ::idleStreams then it will stop highTimers (i.e. server based
scrolling animation) as well as streaming .....

Until we get client side scrolling on SB2, would it be possible to call ::idleStreams whenever you do something which takes time.
[ideally once every X sec, where X is the scrollRate]

Adrian
----- Original Message -----
From: <dsully (AT) svn (DOT) slimdevices.com>
To: <checkins (AT) lists (DOT) slimdevices.com>
Sent: Tuesday, June 21, 2005 7:34 PM
Subject: [Slim-Checkins] r3477 - branches/playlistdb-bmf/server/Slim/Player


> Author: dsully
> Date: 2005-06-21 11:34:35 -0700 (Tue, 21 Jun 2005)
> New Revision: 3477
>
> Modified:
> branches/playlistdb-bmf/server/Slim/Player/Client.pm
> Log:
> Bug: N/A
> Description: Don't need idlestreams for clients with large buffers.
>
>
> Modified: branches/playlistdb-bmf/server/Slim/Player/Client.pm
> ================================================== =================
> --- branches/playlistdb-bmf/server/Slim/Player/Client.pm 2005-06-21 16:09:03 UTC (rev 3476)
> +++ branches/playlistdb-bmf/server/Slim/Player/Client.pm 2005-06-21 18:34:35 UTC (rev 3477)
> @@ -886,17 +886,19 @@
> }
> }
>
> -# Don't bother with idle streams if we only have SB2 clients
> +# Don't bother with idle streams if we only have clients with large buffers.
> sub needIdleStreams {
>
> my $needIdleStreams = 0;
>
> for my $client (clients()) {
>
> - if ($client->model ne 'squeezebox2') {
> - $needIdleStreams = 1;
> - last;
> + if ($client->model =~ /^(?:squeezebox2|softsqueeze|http)$/) {
> + next;
> }
> +
> + $needIdleStreams = 1;
> + last;
> }
>
> return $needIdleStreams;
>
>

Dan Sully
2005-06-21, 11:56
* Triode shaped the electrons to say...

>I've not looked at the code for this, but if it avoids calling
>::idleStreams then it will stop highTimers (i.e. server based
>scrolling animation) as well as streaming .....
>
>Until we get client side scrolling on SB2, would it be possible to call
>::idleStreams whenever you do something which takes time. [ideally once
>every X sec, where X is the scrollRate]

Well, the idea here was that in moving the playlist loop from the old
scanning based architecture to being a fast in memory thing, calling
idleStreams was actually making it take longer to complete.

I'll add an idleStreams call after the loop, but before we render.

-D
--
It does not do to leave a live Dragon out of your calculations..