PDA

View Full Version : Encoding of playlist names (BMF branch)



mherger
2005-06-21, 09:01
This is for the BMF branch only (tested on Mandrake 10.1).

Do the stored playlist names need some encoding? "Now playing" is "Es
läuft gerade" in German. When storing this playlist I get "Es l,uft
gerade".

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

Dan Sully
2005-06-21, 10:54
* Michael Herger shaped the electrons to say...

>This is for the BMF branch only (tested on Mandrake 10.1).
>
>Do the stored playlist names need some encoding? "Now playing" is "Es
>läuft gerade" in German. When storing this playlist I get "Es l,uft
>gerade".

This is when you save a playlist? I'll take a look.

What do people think of the branch so far?

-D
--
<dr.pox> wtf? a garbled dingbat makes java switch to DWIM?

kdf
2005-06-21, 11:22
Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:


> What do people think of the branch so far?

I'm seeing a lot of undef warnings for Info.pm line 733
I get a few more for Client.pm but I can't recall the line number from memory.
This one happens mostly when navigating with the remote.

"current playlist" no longer shows the playlist name when one should exist, as
in after loading an album, or loading a saved playlist.

saving an unnamed playlist comes up with 'Rename' in the form instead of 'save',
although given the automatic naming to "now playing - player" this may be by
design

saving over an existing playlist name causes a crash, column 'url' is not
unique. Probably due to the renamePlaylist() in which create() is called after
assigning a url.

after saving a playlist, the playlist lising disappears. This could likely be
something slimilar to the fix I put in last night to savePlaylist().

how often are the db playlists saved out to files? I made a few new playlists
last night, then went to look (after crashing a few minutes later due to the
above) and the files hadn't been written out yet.

BMF seems to work very nicely. The playlist handling is almost there, but not
quite.

-kdf

Dan Sully
2005-06-21, 11:28
* kdf shaped the electrons to say...

>> What do people think of the branch so far?
>
>I'm seeing a lot of undef warnings for Info.pm line 733
>I get a few more for Client.pm but I can't recall the line number from memory.
>This one happens mostly when navigating with the remote.

What menus are you navigating to?

>"current playlist" no longer shows the playlist name when one should exist, as
>in after loading an album, or loading a saved playlist.

I don't quite follow here..

>saving an unnamed playlist comes up with 'Rename' in the form instead of 'save',
>although given the automatic naming to "now playing - player" this may be by
>design
>
>saving over an existing playlist name causes a crash, column 'url' is not
>unique. Probably due to the renamePlaylist() in which create() is called after
>assigning a url.

I'll get these fixed.

>after saving a playlist, the playlist lising disappears. This could likely be
>something slimilar to the fix I put in last night to savePlaylist().

The listing in the right-hand pane?

>how often are the db playlists saved out to files? I made a few new playlists
>last night, then went to look (after crashing a few minutes later due to the
>above) and the files hadn't been written out yet.

They aren't yet - it's on the Todo list.

> BMF seems to work very nicely.

Good to hear.

-D
--
<faisal> my life is collapsing to what will soon be NEGATIVE INTEGER degrees of separation.

kdf
2005-06-21, 11:49
Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:

> * kdf shaped the electrons to say...
>
> >> What do people think of the branch so far?
> >
> >I'm seeing a lot of undef warnings for Info.pm line 733
> >I get a few more for Client.pm but I can't recall the line number from
> memory.
> >This one happens mostly when navigating with the remote.
>
> What menus are you navigating to?

I think it was search results...

>
> >"current playlist" no longer shows the playlist name when one should exist,
> as
> >in after loading an album, or loading a saved playlist.
>
> I don't quite follow here..

Under the status header, where is says "current playlist: save download clear"
it would show the name of the playlist, where possible.

>
> >after saving a playlist, the playlist lising disappears. This could likely
> be
> >something slimilar to the fix I put in last night to savePlaylist().
>
> The listing in the right-hand pane?

left hand. renamePlaylist() still refers to browse_playlist, whereas
deletePlaylist() and savePlaylist() both return browseDB. I've attached a
screenshot after loading the musicmagic:duplicates playlist. Dean added the
feature a while back.

>
> > BMF seems to work very nicely.
>
> Good to hear.

yeah, for me it seems as fast as I ever remember it being. Due to the time
spent fixing the fishbone skin, and the more noticeable nature of the playlist
issues, I haven't been looking very carefully at any background stuff during
BMF. However, from what I understand, most of the background crap has been
removed anyway :)

Dan Sully
2005-06-21, 16:28
* kdf shaped the electrons to say...

>> I don't quite follow here..
>
>Under the status header, where is says "current playlist: save download clear"
>it would show the name of the playlist, where possible.

This appears to be broken in the trunk as well.

>left hand. renamePlaylist() still refers to browse_playlist, whereas
>deletePlaylist() and savePlaylist() both return browseDB. I've attached a
>screenshot after loading the musicmagic:duplicates playlist. Dean added the
>feature a while back.

Ok.

-D
--
"It has become appallingly obvious that our technology has exceeded our humanity." - Albert Einstein

kdf
2005-06-21, 16:41
Quoting Dan Sully <dan (AT) slimdevices (DOT) com>:

> * kdf shaped the electrons to say...
>
> >> I don't quite follow here..
> >
> >Under the status header, where is says "current playlist: save download
> clear"
> >it would show the name of the playlist, where possible.
>
> This appears to be broken in the trunk as well.

that screencap was from a fairly recent copy of the trunk. I ftp'd it from home
this morning. it doesn't always show the playlist name, only when one is
available.

-k

JJZolx
2005-06-21, 18:03
What do people think of the branch so far?

Is there a compiled Windows version of the branch?

If not, what would be the procedure for downloading and testing the branch? Beyond installing Perl for Windows...

Dan Sully
2005-06-21, 18:13
* JJZolx shaped the electrons to say...

>> What do people think of the branch so far?
>
>Is there a compiled Windows version of the branch?
>
>If not, what would be the procedure for downloading and testing the
>branch? Beyond installing Perl for Windows...

You'll need to download Subversion first - packages can be found here:

http://subversion.tigris.org/project_packages.html

You might also want to download TortiseSVN:

http://tortoisesvn.tigris.org/download.html

Then from either one - you'll want to checkout:

svn co http://svn.slimdevices.com/repos/slim/branches/playlistdb-bmf/server

-D

Dan Sully
2005-06-21, 20:23
* kdf shaped the electrons to say...

>that screencap was from a fairly recent copy of the trunk. I ftp'd it from home
>this morning. it doesn't always show the playlist name, only when one is
>available.

I found the issues and fixed everything that you stated in your previous email.

-D
--
<dr.pox> NO, NETBSD IS NOT REALLY BUILT WITH ELITE FORTRAN77!!@$#$

mherger
2005-06-21, 23:07
>> Do the stored playlist names need some encoding? "Now playing" is "Es
>> läuft gerade" in German. When storing this playlist I get "Es l,uft
>> gerade".
>
> This is when you save a playlist? I'll take a look.

Just tested again. Maybe I was using a very old version or the behaviour
changed recently. But now the playlist's name does not default to "now
playing - something" any more. "Untitled" doesn't contain any special
character.

Manually entered names are stored correctly.

> What do people think of the branch so far?

Didn't do too much testing so far... Will do some testing later today.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

mherger
2005-07-02, 14:07
I'm rather late with this answer... but somebody else just brought up the
topic again:

>> Do the stored playlist names need some encoding? "Now playing" is "Es
>> läuft gerade" in German. When storing this playlist I get "Es l,uft
>> gerade".
>
> This is when you save a playlist? I'll take a look.

It's for the automatically stored "now playing" playlists that also appear
in the "Browse playlist" screen. I opened a bug for this:

http://bugs.slimdevices.com/show_bug.cgi?id=1743

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)