PDA

View Full Version : [Slim-Checkins] r3468 -trunk/server/Slim/Buttons/Input



Dan Sully
2005-06-20, 16:20
This is broken:

Scalar found where operator expected at /usr/local/slim/Slim/Buttons/Input/Bar.pm line 256, near "$valueRef
$valueRef"
(Missing operator before $valueRef?)
syntax error at /usr/local/slim/Slim/Buttons/Input/Bar.pm line 256, near "$valueRef
$valueRef "
Global symbol "$value" requires explicit package name at /usr/local/slim/Slim/Buttons/Input/Bar.pm line 256.
Compilation failed in require at slimserver.pl line 219.
BEGIN failed--compilation aborted at slimserver.pl line 219.

* grotus (AT) svn (DOT) slimdevices.com shaped the electrons to say...

>Author: grotus
>Date: 2005-06-20 15:31:23 -0700 (Mon, 20 Jun 2005)
>New Revision: 3468
>
>Modified:
> trunk/server/Slim/Buttons/Input/Bar.pm
>Log:
>Safer, less stylish way to convert valueRef from a scalar to a reference.
>
>Modified: trunk/server/Slim/Buttons/Input/Bar.pm
>================================================== =================
>--- trunk/server/Slim/Buttons/Input/Bar.pm 2005-06-20 22:22:33 UTC (rev 3467)
>+++ trunk/server/Slim/Buttons/Input/Bar.pm 2005-06-20 22:31:23 UTC (rev 3468)
>@@ -252,7 +252,8 @@
> $$valueRef = $listRef->[$listIndex];
> $client->param('valueRef',$valueRef);
> } elsif (!ref($valueRef)) {
>- $$valueRef = $valueRef;
>+ my $value = $valueRef
>+ $valueRef = \$value;
> $client->param('valueRef',$valueRef);
> }
> if ($$valueRef != $listRef->[$listIndex]) {
>
>

Dan Sully
2005-06-20, 16:23
* Dan Sully shaped the electrons to say...

>This is broken:

Looks like it's just a missing semi-colon. I'll fix.

-D

Robert Moser
2005-06-20, 19:41
Dan Sully blurted out:
> * Dan Sully shaped the electrons to say...
>
>> This is broken:
>
>
> Looks like it's just a missing semi-colon. I'll fix.
>
> -D
>