PDA

View Full Version : [Slim-Checkins] r3418 - trunk/server/Slim/Buttons



kdf
2005-06-16, 21:29
Begin forwarded message:
>
> Description: Use the parameters to INPUT.List better.
>
> BrowseDB.pm
> - Don't specify valueRef since it isn't being used.
> - Use an onChange procedure to update $client->lastID3Selection
>
> Home.pm
> - Use a correct reference for valueRef.
> - Remove unneeded onChange procedure.
>

Would i be correct in surmising that this change would happen to be a
valid fix for bug 1467?
http://bugs.slimdevices.com/show_bug.cgi?id=1467

-kdf

Robert Moser
2005-06-16, 22:43
kdf blurted out:
>
> Begin forwarded message:
>> Description: Use the parameters to INPUT.List better.
>> BrowseDB.pm
>> - Don't specify valueRef since it isn't being used.
>> - Use an onChange procedure to update $client->lastID3Selection

> Would i be correct in surmising that this change would happen to be a
> valid fix for bug 1467?
> http://bugs.slimdevices.com/show_bug.cgi?id=1467
>
> -kdf

Well, what do you know, it will fix that right up. Is there any way to
edit the checkin log to put a reference to that bug in there?

kdf
2005-06-16, 23:11
Quoting Robert Moser <rlmoser (AT) comcast (DOT) net>:

>
> Well, what do you know, it will fix that right up. Is there any way to
> edit the checkin log to put a reference to that bug in there?

no way that I know of, but a note in the bug "change xxxx" will at least link to
that.

I think also, your change 3417 probably helped bug 1678 as well. i've already
put a note there earlier and dean seems to have marked it fixed

yer the psychic bugstomper!

-k

Marc Sherman
2005-06-17, 05:40
Robert Moser wrote:
>
> Well, what do you know, it will fix that right up. Is there any way
> to edit the checkin log to put a reference to that bug in there?

$ svn propset svn:log --revprop -r REV -F NEWLOG.TXT

That has to be specifically enabled in the svn server (with
pre-revprop-change and post-revprop-change hook scrips); if it's not
enabled, then the admins can locally fix the log message with:

# svnadmin setlog REPOS NEWLOG.TXT -r REV

- Marc

Robert Moser
2005-06-17, 07:07
kdf wrote:
> Quoting Robert Moser <rlmoser (AT) comcast (DOT) net>:
>
>
>>Well, what do you know, it will fix that right up. Is there any way to
>>edit the checkin log to put a reference to that bug in there?
>
>
> no way that I know of, but a note in the bug "change xxxx" will at least link to
> that.
>
> I think also, your change 3417 probably helped bug 1678 as well. i've already
> put a note there earlier and dean seems to have marked it fixed
>
> yer the psychic bugstomper!
>
> -k

It isn't really applicable to bug 1678. The change in 3417 only makes a
difference when you navigate to an ALL_X entry. Bug 1678 is more
general in that it also applies to navigating to single entries.