PDA

View Full Version : [Slim-Checkins] r3374 - in trunk/server/Slim:Music Web



Robert Moser
2005-06-11, 14:26
kdf (AT) svn (DOT) slimdevices.com blurted out:
> Author: kdf
> Date: 2005-06-11 10:55:52 -0700 (Sat, 11 Jun 2005)
> New Revision: 3374
>
> Modified:
> trunk/server/Slim/Music/Info.pm
> trunk/server/Slim/Web/Setup.pm
> Log:
> Bug: 1650
> Description: No Album displayed in player UI. In elemlookup, return
> undef if the element value matches the string for no data. This will
> work for NO_GENRE, NO_ALBUM and NO_ARTIST
>
> Modified: trunk/server/Slim/Music/Info.pm
> ================================================== =================
> --- trunk/server/Slim/Music/Info.pm 2005-06-10 20:27:51 UTC (rev 3373)
> +++ trunk/server/Slim/Music/Info.pm 2005-06-11 17:55:52 UTC (rev 3374)
> @@ -456,6 +456,7 @@
> my $discCount = $infoHashref->{"DISCC"};
> return undef if defined $discCount and $discCount == 1;
> }
> + return undef if defined $infoHashref->{$element} and Slim::Utils::Strings::stringExists("NO_".$element) and $infoHashref->{$element} eq string("NO_".$element);
>
> return $infoHashref->{$element};
> }
>

One thing I've been wondering, do we update the NO_* strings in the
database if the language changes?

dean
2005-06-11, 14:31
Excellent point!

Maybe we should keep the language neutral NO_* string in the DB and
check against that later?

Or better yet, leave the value undefined in the database.


On Jun 11, 2005, at 2:26 PM, Robert Moser wrote:

>
> kdf (AT) svn (DOT) slimdevices.com blurted out:
>
>> Author: kdf
>> Date: 2005-06-11 10:55:52 -0700 (Sat, 11 Jun 2005)
>> New Revision: 3374
>> Modified:
>> trunk/server/Slim/Music/Info.pm
>> trunk/server/Slim/Web/Setup.pm
>> Log:
>> Bug: 1650
>> Description: No Album displayed in player UI. In elemlookup, return
>> undef if the element value matches the string for no data. This will
>> work for NO_GENRE, NO_ALBUM and NO_ARTIST
>> Modified: trunk/server/Slim/Music/Info.pm
>> ================================================== =================
>> --- trunk/server/Slim/Music/Info.pm 2005-06-10 20:27:51 UTC
>> (rev 3373)
>> +++ trunk/server/Slim/Music/Info.pm 2005-06-11 17:55:52 UTC
>> (rev 3374)
>> @@ -456,6 +456,7 @@
>> my $discCount = $infoHashref->{"DISCC"};
>> return undef if defined $discCount and $discCount == 1;
>> }
>> + return undef if defined $infoHashref->{$element} and
>> Slim::Utils::Strings::stringExists("NO_".$element) and
>> $infoHashref->{$element} eq string("NO_".$element);
>> return $infoHashref->{$element};
>> }
>>
>
> One thing I've been wondering, do we update the NO_* strings in the
> database if the language changes?
>

kdf
2005-06-11, 14:33
Quoting Robert Moser <rlmoser (AT) comcast (DOT) net>:


> One thing I've been wondering, do we update the NO_* strings in the
> database if the language changes?

Offhand, I'd say no :)

probably nice if it was the token that was stored...


-kdf

kdf
2005-06-11, 14:51
Quoting dean blackketter <dean (AT) slimdevices (DOT) com>:

> Excellent point!
>
> Maybe we should keep the language neutral NO_* string in the DB and
> check against that later?
>
> Or better yet, leave the value undefined in the database.

depends on if you might want the 'no artist' as an item in the browse list or
not. undef would be fine if you want them invisible.

either way, its a big change. It affects the change in the subject, but also
web status for most skins, browse lists in web and player.

-kdf