PDA

View Full Version : ExBrowse2 request for testing



Jacob Potter
2005-06-01, 13:07
Hi all -

I recently checked in a major rewrite of ExBrowse2, based on "JXTK",
my very own AJAX library. (If you're curious, check out
HTML/EN/html/jxtk/*.js). As far as I know it's working well, but I
could use some more testing. Browsers, settings, vew options, etc.
I've tested it in IE 6, Firefox, and Safari, but it should work in
other browsers as well.

Once ExBrowse2 is well-tested, I'll port Default2 over. Using a common
library should make the two skins much more maintainable and
extensible, as all the non-skin-spectific work is moved out of the
skin itself and into the library.

So I'd appreciate it if people could give this a try. It's in svn as
of last night, replacing the old ExBrowse2 code.

Thanks!

- Jacob

Caleb Epstein
2005-06-01, 13:57
On Wed, Jun 01, 2005 at 04:07:53PM -0400, Jacob Potter wrote:

> Hi all - I recently checked in a major rewrite of ExBrowse2, based
> on "JXTK",

Its not working for me with IE6 or Mozilla 1.0.3. In Mozilla,
I get the top 3 lines of the left pane (Music Library ...,
Search Music, blank gray line) and an empty set of controls in
the right hand pane (e.g. the images and labels are rendered,
but no playlist appears). Overlaying the page in the top left
is "Loading..."

In IE6 I juyst see "Loading..." on a black background.

--
| |Women are more easily and more deeply terrified
Caleb Epstein | bklyn . org |... generating more sheer horror than the male
cae at | Brooklyn Dust |of the species.
bklyn dot org | Bunny Mfg. | -- Spock, "Wolf in the Fold",
| | stardate 3615.4

Caleb Epstein
2005-06-01, 13:59
On Wed, Jun 01, 2005 at 04:57:56PM -0400, Caleb Epstein wrote:

> Its not working for me with IE6 or Mozilla 1.0.3. In Mozilla,


By Mozilla I mean Firefox. Platform is Windows 2000

--
Caleb Epstein | bklyn . org | Some people's mouths work faster than their
cae at | Brooklyn Dust | brains. They say things they haven't even
bklyn dot org | Bunny Mfg. | thought of yet.

Ben Sandee
2005-06-01, 14:18
On 6/1/05, Caleb Epstein <cae (AT) bklyn (DOT) org> wrote:
> On Wed, Jun 01, 2005 at 04:07:53PM -0400, Jacob Potter wrote:
>
> > Hi all - I recently checked in a major rewrite of ExBrowse2, based
> > on "JXTK",
>
> Its not working for me with IE6 or Mozilla 1.0.3. In Mozilla,
> I get the top 3 lines of the left pane (Music Library ...,
> Search Music, blank gray line) and an empty set of controls in
> the right hand pane (e.g. the images and labels are rendered,
> but no playlist appears). Overlaying the page in the top left
> is "Loading..."
>
> In IE6 I juyst see "Loading..." on a black background.

I can confirm these results too, except I'm using Deer Park Alpha 1
(aka Firefox 1.1 alpha) Same results as Caleb for IE6. Did something
get missed in the checkin?

Ben

Jacob Potter
2005-06-01, 14:18
On 6/1/05, Caleb Epstein <cae (AT) bklyn (DOT) org> wrote:
>
> By Mozilla I mean Firefox. Platform is Windows 2000
>

Anything in the Javascript console?

Caleb Epstein
2005-06-01, 14:23
On Wed, Jun 01, 2005 at 05:18:57PM -0400, Jacob Potter wrote:

> On 6/1/05, Caleb Epstein <cae (AT) bklyn (DOT) org> wrote:
> >
> > By Mozilla I mean Firefox. Platform is Windows 2000
> >
>
> Anything in the Javascript console?

Error: mainload is not defined

--
Caleb Epstein | bklyn . org | Never argue with a fool -- people might not
cae at | Brooklyn Dust | be able to tell the difference.
bklyn dot org | Bunny Mfg. |

Ben Sandee
2005-06-01, 14:26
Javascript log from Deer Park Alpha 1:

Error: Expected declaration but found '/'. Skipped to next declaration.
Source File: http://cedar:9000/slimserver.css
Line: 40
(repeats)

Error: mainload is not defined
Source File: http://cedar:9000/
Line: 1

Error: scrollfix is not defined
Source File: http://cedar:9000/
Line: 1
(repeats)

Ben

Jacob Potter
2005-06-01, 14:43
On 6/1/05, Ben Sandee <tbsandee (AT) gmail (DOT) com> wrote:
> Javascript log from Deer Park Alpha 1:
(snip)

Hmm, you think "main.js" might have been important?

It's in svn, along with the correct URL for the xml pages. Changes
3320 and 3321.

Sorry for the false alarm, it should be working now.

- Jacob

Caleb Epstein
2005-06-01, 14:44
On Wed, Jun 01, 2005 at 05:43:44PM -0400, Jacob Potter wrote:

> On 6/1/05, Ben Sandee <tbsandee (AT) gmail (DOT) com> wrote: > Javascript log
> from Deer Park Alpha 1: (snip) Hmm, you think "main.js" might have
> been important? It's in svn, along with the correct URL for the xml
> pages. Changes 3320 and 3321. Sorry for the false alarm, it should
> be working now.

I can confirm that all is well with r3321

--
Caleb Epstein | bklyn . org | <SilverStr> media ethics is an oxymoron,
cae at | Brooklyn Dust | much like Jumbo Shrimp and
bklyn dot org | Bunny Mfg. | Microsoft Works.
| | <MonkAway> not to mention NT Security

Ben Sandee
2005-06-01, 14:51
On 6/1/05, Jacob Potter <jacobdp (AT) gmail (DOT) com> wrote:
> On 6/1/05, Ben Sandee <tbsandee (AT) gmail (DOT) com> wrote:
> > Javascript log from Deer Park Alpha 1:
> (snip)
>
> Hmm, you think "main.js" might have been important?
>
> It's in svn, along with the correct URL for the xml pages. Changes
> 3320 and 3321.
>

Looks great now! Any chance it's an easy fix to make URL's like this:

http://cedar:9000/index.html?player=00:04:20:05:a2:41

work to select the default active player? This works with default skin.

If not that, is it possible to have it remember the last active
player? It seems to default to the first player in the list right now
which is two floors away from me right now....

The playlist reordering is EXTREMELY cool though!

Ben

Caleb Epstein
2005-06-01, 14:54
On Wed, Jun 01, 2005 at 04:51:58PM -0500, Ben Sandee wrote:

> The playlist reordering is EXTREMELY cool though!

I didn't notice this feature until you mentioned it, but
yes it is. Wow.

--
Caleb Epstein | bklyn . org |
cae at | Brooklyn Dust | And now for something completely different.
bklyn dot org | Bunny Mfg. |

Jacob Potter
2005-06-01, 14:57
On 6/1/05, Ben Sandee <tbsandee (AT) gmail (DOT) com> wrote:
> On 6/1/05, Jacob Potter <jacobdp (AT) gmail (DOT) com> wrote:
> > On 6/1/05, Ben Sandee <tbsandee (AT) gmail (DOT) com> wrote:
> > > Javascript log from Deer Park Alpha 1:
> > (snip)
> >
> > Hmm, you think "main.js" might have been important?
> >
> > It's in svn, along with the correct URL for the xml pages. Changes
> > 3320 and 3321.
> >
>
> Looks great now! Any chance it's an easy fix to make URL's like this:
>
> http://cedar:9000/index.html?player=00:04:20:05:a2:41
>
> work to select the default active player? This works with default skin.
>
> If not that, is it possible to have it remember the last active
> player? It seems to default to the first player in the list right now
> which is two floors away from me right now....

Shouldn't be too hard either way. I'll work on it...

Glad you like it!

- Jacob

Jacob Potter
2005-06-01, 16:19
On 6/1/05, Ben Sandee <tbsandee (AT) gmail (DOT) com> wrote:
> Looks great now! Any chance it's an easy fix to make URL's like this:
>
> http://cedar:9000/index.html?player=00:04:20:05:a2:41
>
> work to select the default active player? This works with default skin.
>
> If not that, is it possible to have it remember the last active
> player? It seems to default to the first player in the list right now
> which is two floors away from me right now....

Both should work now, as of svn 3324.

> The playlist reordering is EXTREMELY cool though!

Thanks! :)

- Jacob

Ben Sandee
2005-06-01, 16:44
On 6/1/05, Jacob Potter <jacobdp (AT) gmail (DOT) com> wrote:
> Both should work now, as of svn 3324.

Jacob,

Thanks for working on this! After updating I'm getting this error in
the console when I go to the main url:

Error: this.xml has no properties
Source File: http://cedar:9000/html/jxtk/backend.js
Line: 163

If I include the playerid then it seems to work -- but it doesn't seem
to be selecting the right player. Still defaults to the first one in
the list. Any ideas?

Ben

Robert Moser
2005-06-02, 07:26
Ben Sandee wrote:
> Jacob,
>
> Thanks for working on this! After updating I'm getting this error in
> the console when I go to the main url:
>
> Error: this.xml has no properties
> Source File: http://cedar:9000/html/jxtk/backend.js
> Line: 163
>
> If I include the playerid then it seems to work -- but it doesn't seem
> to be selecting the right player. Still defaults to the first one in
> the list. Any ideas?
>
> Ben

loadHome in home.js should fall back to
currentPlayer = document.getElementById("playersel").value;
if currentPlayer doesn't exist after that if (qpos < 0 ) {} else {} bit.

Jacob Potter
2005-06-02, 09:45
On 6/2/05, Robert Moser <rlmoser (AT) comcast (DOT) net> wrote:
> loadHome in home.js should fall back to
> currentPlayer = document.getElementById("playersel").value;
> if currentPlayer doesn't exist after that if (qpos < 0 ) {} else {} bit.

Actually, that bit happens before playersel is initialized. If
currentPlayer isn't set there, it'll have an invalid value and be
reset in homeHandler(), after home.xml and the player list are loaded.

I'll keep working on it...

- Jacob

max.spicer
2005-06-02, 10:59
I do like the drag and drop playlist editing! It took me a brief while to work out how to use it though. The drag icon still looks as if you should click on the up or down arrow. My first thing was to try clicking on the song title and then dragging that. Would it be be possible to make this work as well?

I've found that you can confuse things by dragging a song above the currently playing song. If the currently playing song is first in the playlist, and you drag something above it, the following things happen:
- Clicking the rewind button makes the last item in the playlist play, rather than the item that you have dragged to be first.
- Clicking pause makes the new top item in the playlist be highlighted. Clicking pause again continues the song, but the interface now shows that the wrong song is playing.

In general, there is a much longer delay between clicking on a song in the playlist and it starting to play than usual.

Sorry for these criticisms, the work you've put in is great - I'm looking forward to this making its way into default2!

I previously posted problems with my browser hanging (http://forums.slimdevices.com/showthread.php?t=14462). These problems now seem to have been fixed.

Max

gorstk
2005-06-02, 12:04
Jacob Potter wrote:

> So I'd appreciate it if people could give this a try. It's in svn as
> of last night, replacing the old ExBrowse2 code.

Working well on Firefox (Linux) and Internet Explorer 6 (XP).

My only criticism is that The left hand pane seems to take up 2/3 of the
width of the display, and the playlist view takes up only 1/3. I think
the split should be much more of a 50:50 split or a 55:45 split, this
way the right hand pane would not require a horizontal scroll bar to fit
on all the text.

Cheers

gorstk
2005-06-02, 12:11
Jacob Potter wrote:

> So I'd appreciate it if people could give this a try. It's in svn as
> of last night, replacing the old ExBrowse2 code.

The power on-off buttons do not seem active at all on exbrose.

The power on-off seems to be also broken in Default (standard version),
it lets me switch the player on but then wont let me swtich it off (even
though the player is on it remains highlighting the off section).

This is not a problem at all with the Handheld skin.

Any ideas?

Jacob Potter
2005-06-02, 15:19
On 6/2/05, max. spicer <max.spicer.1q0ge0 (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> I do like the drag and drop playlist editing! It took me a brief while
> to work out how to use it though. The drag icon still looks as if you
> should click on the up or down arrow. My first thing was to try
> clicking on the song title and then dragging that. Would it be be
> possible to make this work as well?

I tried, but I couldn't make it not register a click on the song title
after the drag finished. (The author of the drag-and-drop library I'm
using wasn't able to have dragging a link work reliably either, so
it's a difficult problem).

Maybe changing the cursor over the drag handle to a "move" icon would
give enough indication?

> I've found that you can confuse things by dragging a song above the
> currently playing song. If the currently playing song is first in the
> playlist, and you drag something above it, the following things
> happen:

Strange, I haven't been able to reproduce this.

> In general, there is a much longer delay between clicking on a song in
> the playlist and it starting to play than usual.

Fixed. Try this patch (I'll put it in svn once I get some more of the
remaining issues worked out, it'll be in tomorrow's nightly)

Thanks for the help!

- Jacob

gorstk
2005-06-03, 08:30
Jacob Potter wrote:

>>In general, there is a much longer delay between clicking on a song in
>>the playlist and it starting to play than usual.
>
>
> Fixed. Try this patch (I'll put it in svn once I get some more of the
> remaining issues worked out, it'll be in tomorrow's nightly)
>

Running 3/6/5 nightly on Linux, SB1, Firefox, PIII 1ghz 512mb

When I skip one song using the exbrowse interface or click on a
different song, the new track starts playing instantly.

If I click on the skip (ffwd) button several times the web page updates
instantly (and smoothly) to the new track..... but the display on the
SB1 flicks though the skipped songs for a few seconds. (2 seconds for 5
songs).

I do not know if there is anything you can do about this in the
skin?Just seems a shame that the skin would be so much slicker than the
SB1 itself! I assume it is because slimserver attempts to start playing
and accesses the database for each of the five songs in very fast
succession.

Maybe holding down on the fwwd button will skip a song every ?0.3 it is
held down, and only when it is released it would tell the player to skip
to that song? This would avoid the multiple stopping and starting.

Although I guess this is not so much of a problem because we could just
click on the song we want to skip to! Nothing wrong with aiming for
perfection, as I think this skin is getting there!

One other thing in the playlist view on the right hand side of the
screen, if I click on either the track name, artist or album it skips to
that track. Would it be possible so that only if you click on the
track it would skip to that song. If you clicked on artist or album it
would browse to that artist/album on the left hand page??

Also any chance of making the right hand side pane wider? (or atleast an
option to make it wider - although could not see what to change in the
html file to make it wider..... probably more a reflection on my less
than basic html skills!)

One last thing! The playlist Save/Download/Clear buttons arent working
both on IE6 and FireFox. When I click these buttons nothing happens. On
IE I get the following error messgae:
Line: 87
Char: 1
Code: 0
URL http://192.168.100.3/ExBrowse2/

Hope this feedback helps

Jacob Potter
2005-06-03, 13:30
On 6/3/05, John Gorst <john_gorst (AT) hotmail (DOT) com> wrote:
> If I click on the skip (ffwd) button several times the web page updates
> instantly (and smoothly) to the new track..... but the display on the
> SB1 flicks though the skipped songs for a few seconds. (2 seconds for 5
> songs).
>
> I do not know if there is anything you can do about this in the
> skin?Just seems a shame that the skin would be so much slicker than the
> SB1 itself! I assume it is because slimserver attempts to start playing
> and accesses the database for each of the five songs in very fast
> succession.

Right.

I think the best thing to do is have it skip immediately the first
time that the button is pressed, but if it's pressed multiple times
quickly then add a brief delay before the command is sent to
SlimServer.

Meaning, change click (send) click (send) click (send) click (send)....
to something like click (send) click click click ... (send)

> One other thing in the playlist view on the right hand side of the
> screen, if I click on either the track name, artist or album it skips to
> that track. Would it be possible so that only if you click on the
> track it would skip to that song. If you clicked on artist or album it
> would browse to that artist/album on the left hand page??

If you have artist and album set in your title format (server settings
-> formatting), then that'll happen because the server presents "song
from album by artist" as the title of the song. If artist and album
aren't included, ExBrowse2 adds an artist link (no album yet, I'll add
that though) that will take you to the artist page.

So it's already there :)

> Also any chance of making the right hand side pane wider? (or atleast an
> option to make it wider - although could not see what to change in the
> html file to make it wider..... probably more a reflection on my less
> than basic html skills!)

All the layout is defined in slimserver.css. The current setup won't
scale easily though, as all the widths and positions are hardcoded. I
should fix that, but the current priority is to get everything
working.

> One last thing! The playlist Save/Download/Clear buttons arent working
> both on IE6 and FireFox. When I click these buttons nothing happens. On
> IE I get the following error messgae:

Fixed for the next nightly (svn 3338).

> Hope this feedback helps

It definitely does, thanks!

- Jacob

gorstk
2005-06-04, 05:47
Jacob Potter wrote:

> I think the best thing to do is have it skip immediately the first
> time that the button is pressed, but if it's pressed multiple times
> quickly then add a brief delay before the command is sent to
> SlimServer.
>
> Meaning, change click (send) click (send) click (send) click (send)....
> to something like click (send) click click click ... (send)
Sounds good!



> If you have artist and album set in your title format (server settings
> -> formatting), then that'll happen because the server presents "song
> from album by artist" as the title of the song. If artist and album
> aren't included, ExBrowse2 adds an artist link (no album yet, I'll add
> that though) that will take you to the artist page.
>
> So it's already there :)

Sounds very good. Thought initially this wouldnt mean I could have title
-artist -album display on the SB1 itself, but that aint true. If we
could have album as well that would be excellent!

> All the layout is defined in slimserver.css. The current setup won't
> scale easily though, as all the widths and positions are hardcoded. I
> should fix that, but the current priority is to get everything
> working.

OK
>
>
>>One last thing! The playlist Save/Download/Clear buttons arent working
>>both on IE6 and FireFox. When I click these buttons nothing happens. On
>>IE I get the following error messgae:
>
>
> Fixed for the next nightly (svn 3338).

Thank you!

gorstk
2005-06-04, 07:24
John Gorst wrote:

>
>> If you have artist and album set in your title format (server settings
>> -> formatting), then that'll happen because the server presents "song
>> from album by artist" as the title of the song. If artist and album
>> aren't included, ExBrowse2 adds an artist link (no album yet, I'll add
>> that though) that will take you to the artist page.
>>
>> So it's already there :)
>
>
> Sounds very good. Thought initially this wouldnt mean I could have title
> -artist -album display on the SB1 itself, but that aint true. If we
> could have album as well that would be excellent!

Two other quick points:

1) Links to the album/artist where the album/artist are shown at the top
of the left hand side pane

2) Does anyone else find that the powere button on Exbrowse2 and
default(1) do not work correctly (see previosu post)?

Cheers

max.spicer
2005-06-05, 09:24
In R3342, the Album title overlaps the volume display slightly. See the attached screenshot. I'm using Firefox 1.04 on Windows to view the page.

Max

max.spicer
2005-06-05, 09:30
I was wondering what some of the icons do in ExBrowse2 (the add icon is far from intuitive!), so hovered over them to get a tooltip; however, there wasn't one. From the HTML source, I can see that there is an alt attribute that would work well as a tooltip for the Add and Play buttons. Could you put this same text in for the title attribute as well? IE will display alt as a tooltip, but proper browsers don't - they use title instead as that's what it's there for! Given how well ExBrowse2 works in firefox, I suspect I'm preaching to the converted here. ;-)

Max

Jacob Potter
2005-06-05, 10:02
On 6/2/05, John Gorst <john_gorst (AT) hotmail (DOT) com> wrote:
> Jacob Potter wrote:
>
> > So I'd appreciate it if people could give this a try. It's in svn as
> > of last night, replacing the old ExBrowse2 code.
>
> The power on-off buttons do not seem active at all on exbrose.

Fixed in 3343, sorry about that.

> The power on-off seems to be also broken in Default (standard version),
> it lets me switch the player on but then wont let me swtich it off (even
> though the player is on it remains highlighting the off section).

Dunno, Default (original) isn't my skin. I'd ask Dean or Vidur.

- Jacob

Jacob Potter
2005-06-05, 10:05
On 6/5/05, max. spicer <max.spicer.1q5wgb (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> I was wondering what some of the icons do in ExBrowse2 (the add icon is
> far from intuitive!), so hovered over them to get a tooltip; however,
> there wasn't one. From the HTML source, I can see that there is an alt
> attribute that would work well as a tooltip for the Add and Play
> buttons. Could you put this same text in for the title attribute as
> well? IE will display alt as a tooltip, but proper browsers don't -
> they use title instead as that's what it's there for! Given how well
> ExBrowse2 works in firefox, I suspect I'm preaching to the converted
> here. ;-)

Indeed. I'll add that.

About the album/progress bar overlap - did the song title that you had
up at the time wrap to the next line?

- Jacob

Jacob Potter
2005-06-05, 11:32
On 6/5/05, max. spicer <max.spicer.1q5wgb (AT) no-mx (DOT) forums.slimdevices.com> wrote:
> I was wondering what some of the icons do in ExBrowse2 (the add icon is
> far from intuitive!), so hovered over them to get a tooltip; however,
> there wasn't one.

.... Fixed in svn 3344. Tooltips on the add and play links, as well as
move and remove in the playlist editor. Localized properly too.

Keep those bug reports coming!

- Jacob

max.spicer
2005-06-05, 12:24
.... Fixed in svn 3344. Tooltips on the add and play links, as well as
move and remove in the playlist editor. Localized properly too.
- Jacob
How about putting some help text into the tooltip for move. Something like "Move (drag this icon to new position in playlist)". You mentioned setting cursor:move on this icon a while ago - I think that would be a good idea. The typical four pointed cross that this gives is not ideal, but it's an improvement on the hand icon that suggests a single click is required.

Max

cdoherty
2005-06-05, 18:32
On Wed, Jun 01, 2005 at 04:07:53PM -0400, Jacob Potter said:
> So I'd appreciate it if people could give this a try. It's in svn as
> of last night, replacing the old ExBrowse2 code.

I've got svn 3345 checked out. in Firefox 1.0.4 on Debian unstable, the
left-hand pane takes up the entire screen. the JS error when I load the
index is

Error: initHome is not defined
Source File: http://shiny:9000/html/main.js
Line: 22

this breaks the interface in a dozen directions, but appears to be a
simple dependency ordering thing, fixed by the attached patch (putting the
include for home.js before the include for main.js in index.html).

other than that, looks neat. the drag 'n drop ordering is nifty, and
everything feels more responsive.

cheers,
chris


-------------------------------
Chris Doherty
chris [at] randomcamel.net

"I think," said Christopher Robin, "that we ought to eat
all our provisions now, so we won't have so much to carry."
-- A. A. Milne
-------------------------------

cdoherty
2005-06-05, 19:06
On Sun, Jun 05, 2005 at 06:32:52PM -0700, Chris Doherty said:
> other than that, looks neat. the drag 'n drop ordering is nifty, and
> everything feels more responsive.

looks like bugs 1611 and 1612 were fixed somewhere along the line.

two other things with large playlists:

- there's no paging mechanism in the current playlist. I noticed this in
6.0.1, but it's still the case in trunk.

- possibly related, if you load a large playlist and play the last song,
this error appears when hitting the Next button in the interface:

Error: playlist[currentSong - 1] has no properties
Source File: http://shiny:9000/html/status.js
Line: 175

however, if you let that last song play out, it loads the next page of
the current playlist.

couldn't find an easy fix for this one. :-)

this is all still with Firefox 1.0.4 on Debian unstable.

cheers,
chris



-------------------------------
Chris Doherty
chris [at] randomcamel.net

"I think," said Christopher Robin, "that we ought to eat
all our provisions now, so we won't have so much to carry."
-- A. A. Milne
-------------------------------

Craig, James (IT)
2005-06-06, 02:13
> Keep those bug reports coming!

Jacob,
I have quite a few problems with the 6.1 download from Sunday ( I assume
this contains most of your changes);
I'm using Firefox on Windows XP

1) The ExBrowse2 main page doesn't complete loading for me. I get the
header sections on the left and the right, and a loading message on the
top left. I have waited for some time (> 10 minutes) and nothing further
happens. However, if I click on the 'server settings' link,
The settings page appears immediately. A couple of seconds later this
page refreshes and shows the 'new music screen' and everything seems OK!
So I've been loading the interface this way for a while but it doesn't
seem right...
I don't know what's it's doing in this loading phase - I have about
9,000 tracks in my library and many very large playlists

2) the contents of my iTunes playlists cannot be displayed. If I click
on any of them in the browse playlists page I get a page which just
shows the name of my only non-iTunes playlist (they work fine in normal
skins)

3) the current playlist doesn't seem to update when switching between
players

4) the current playlist stopped updating after my server crashed and was
restarted.

James
--------------------------------------------------------

NOTICE: If received in error, please destroy and notify sender. Sender does not waive confidentiality or privilege, and use is prohibited.

gorstk
2005-06-06, 05:27
Jacob Potter wrote:

> So I'd appreciate it if people could give this a try. It's in svn as
> of last night, replacing the old ExBrowse2 code.

6/6/6 nightly, linux slimserver, windows firefox

If I go into standby with a exbrowse open in firefox, when I come out of
standby anything I do in the way of stopping/starting adjusting volume
etc in the right hand pane is ignored until I do a complete browser refresh.

I assume this has something to do with exbrowse remaining 'connected'
constantly to slimserver to update its info, and this is obviously
broken by going into standby.

Is there a way either to
a) reconnect/refresh automatically if the 'connection' is broken e.g.
refresh or I assume loss of wireless signal
b) warn the user that they need to refresh if exbrowse looses its conenction

I have also just noticed that the plugins that have web pages (e.g.
alienbbc, biography and album review) don't appear anywhere in the
ExBrowse skin. You probably knew this anyway, but just thought I would
point it out in case you didnt!

Not major problems, but as I have said before.... making it 'more perfect'!

Cheers

cdoherty
2005-06-06, 20:56
On Sun, Jun 05, 2005 at 07:06:09PM -0700, Chris Doherty said:
> this is all still with Firefox 1.0.4 on Debian unstable.

svn 3346. tried out searching:

- Error: postback is not defined.
Source file: http://shiny:9000/html/search.js line 82

this happens on load: looks like postback.js isn't checked in to the
ExBrowse2/ directory. copying the postback.js from Default2/html/ seems
to have made the incremental search work fine, though I still see the
second error in the JavaScript console...

- Error: parent.abortkey is not a function.

this seems to be a harmless error, but it's fixed anyway with the
attached patch (I copied abortkey() from Default2/html/status.js).


chris


-------------------------------
Chris Doherty
chris [at] randomcamel.net

"I think," said Christopher Robin, "that we ought to eat
all our provisions now, so we won't have so much to carry."
-- A. A. Milne
-------------------------------

cdoherty
2005-06-06, 20:59
too much time spent in Perforce--`svn diff` isn't recursive. second patch
attached.

also ignore the "index.html" bit, that's from a previous fix.

chris


On Mon, Jun 06, 2005 at 08:56:31PM -0700, Chris Doherty said:
> On Sun, Jun 05, 2005 at 07:06:09PM -0700, Chris Doherty said:
> > this is all still with Firefox 1.0.4 on Debian unstable.
>
> svn 3346. tried out searching:
>
> - Error: postback is not defined.
> Source file: http://shiny:9000/html/search.js line 82
>
> this happens on load: looks like postback.js isn't checked in to the
> ExBrowse2/ directory. copying the postback.js from Default2/html/ seems
> to have made the incremental search work fine, though I still see the
> second error in the JavaScript console...
>
> - Error: parent.abortkey is not a function.
>
> this seems to be a harmless error, but it's fixed anyway with the
> attached patch (I copied abortkey() from Default2/html/status.js).
>
>
> chris
>
>
> -------------------------------
> Chris Doherty
> chris [at] randomcamel.net
>
> "I think," said Christopher Robin, "that we ought to eat
> all our provisions now, so we won't have so much to carry."
> -- A. A. Milne
> -------------------------------

> Index: header.html
> ================================================== =================
> --- header.html (revision 3346)
> +++ header.html (working copy)
> @@ -9,6 +9,8 @@
> <meta http-equiv="content-type" content="text/html; charset=[% LOCALE %]"/>[% IF scripts %]
> <script type="text/javascript">var webroot="[% webroot %]";</script>
> <script type="text/javascript" src="[% webroot %]html/postback.js"></script>
> - <script type="text/javascript" src="[% webroot %]html/search.js"></script>[% END %]
> + <script type="text/javascript" src="[% webroot %]html/search.js"></script>
> + <script type="text/javascript" src="[% webroot %]html/status.js"></script>
> + [% END %]
> </head>
> <body onload="if(parent.pushpwd){parent.pushpwd(document.getElem entById('pwd').innerHTML);}document.onkeypress=fun ction(e){if(!e)e=window.event;return parent.[% IF nokbd %]abortkey[% ELSE %]handlekey[% END %](e);};">
> Index: html/status.js
> ================================================== =================
> --- html/status.js (revision 3346)
> +++ html/status.js (working copy)
> @@ -241,3 +241,8 @@
> // updateStatusCombined in each of the templates.
> statusbackend.submit(str);
> }
> +
> +function abortkey(e) {
> + return true;
> +}
> +
> Index: index.html
> ================================================== =================
> --- index.html (revision 3346)
> +++ index.html (working copy)
> @@ -17,10 +17,10 @@
> <script type="text/javascript" src="[% webroot %]html/jxtk/combolist.js"></script>
> <script type="text/javascript" src="[% webroot %]html/jxtk/listbox.js"></script>
> <script type="text/javascript" src="[% webroot %]html/jxtk/textbox.js"></script>
> + <script type="text/javascript" src="[% webroot %]html/home.js"></script>
> <script type="text/javascript" src="[% webroot %]html/main.js"></script>
> <script type="text/javascript" src="[% webroot %]html/status.js"></script>
> <script type="text/javascript" src="[% webroot %]html/playlist.js"></script>
> - <script type="text/javascript" src="[% webroot %]html/home.js"></script>
> <script type="text/javascript" src="[% webroot %]html/toolmanx/core.js"></script>
> <script type="text/javascript" src="[% webroot %]html/toolmanx/coordinates.js"></script>
> <script type="text/javascript" src="[% webroot %]html/toolmanx/css.js"></script>

>

Jacob Potter
2005-06-07, 17:05
On 6/6/05, Chris Doherty <chris-slimdevices (AT) randomcamel (DOT) net> wrote:
> svn 3346. tried out searching:
>
> - Error: postback is not defined.
> Source file: http://shiny:9000/html/search.js line 82

Fixed. "postback.js" is deprecated, I've replaced it with the
JXTK.Backend() class.

> - Error: parent.abortkey is not a function.

Also fixed. (svn 3351)

Thanks!

- Jacob

Jacob Potter
2005-06-07, 17:09
On 6/6/05, John Gorst <john_gorst (AT) hotmail (DOT) com> wrote:
> Is there a way either to
> a) reconnect/refresh automatically if the 'connection' is broken e.g.
> refresh or I assume loss of wireless signal
> b) warn the user that they need to refresh if exbrowse looses its conenction

OK, as of svn 3351 it'll put up a message if the connection is lost,
and then auto-refresh five seconds after that.

> I have also just noticed that the plugins that have web pages (e.g.
> alienbbc, biography and album review) don't appear anywhere in the
> ExBrowse skin. You probably knew this anyway, but just thought I would
> point it out in case you didnt!

Right. I'll work on getting those in.

- Jacob

gorstk
2005-06-08, 12:49
Jacob Potter wrote:
> On 6/6/05, John Gorst <john_gorst (AT) hotmail (DOT) com> wrote:
>
>>Is there a way either to
>>a) reconnect/refresh automatically if the 'connection' is broken e.g.
>>refresh or I assume loss of wireless signal
>>b) warn the user that they need to refresh if exbrowse looses its conenction
>
>
> OK, as of svn 3351 it'll put up a message if the connection is lost,
> and then auto-refresh five seconds after that.

Seems like it aint waiting five seconds or that it is counting from five
after it /starts/ coming out of standby rather than whether it is
fully came out of standby and attempting to get network (DHCP) info.

This means that when I come out of standby almost straight away it is
coming up with an error message saying 'unable to connect to....'.

Update: This only happens in Firefox 1.03 XP. Internet Explorer 6 does
not even seem to 'drop' the connection when going into and ocming out of
standby.