PDA

View Full Version : Missing feedback when playing/adding streams with theremote



mherger
2005-05-27, 00:14
I thought there was some message like "Adding to playlist" when a stream
was selected from the remote control. Right now there's no feedback to the
user at all. Has this been removed? Should I add a showBriefly() to the
radio plugins?

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

kdf
2005-05-27, 00:42
Quoting Michael Herger <slim (AT) herger (DOT) net>:

> I thought there was some message like "Adding to playlist" when a stream
> was selected from the remote control. Right now there's no feedback to the
> user at all. Has this been removed? Should I add a showBriefly() to the
> radio plugins?

on the face of it, that sounds like a great idea. I'm wondering what used to
handle those messages, however. I would have expected that this was done via
showBriefly in older versions. I dont recall ever having any sort of global
message code for adding to a playlist.
-k

kdf
2005-05-27, 00:42
Quoting Michael Herger <slim (AT) herger (DOT) net>:

> I thought there was some message like "Adding to playlist" when a stream
> was selected from the remote control. Right now there's no feedback to the
> user at all. Has this been removed? Should I add a showBriefly() to the
> radio plugins?

on the face of it, that sounds like a great idea. I'm wondering what used to
handle those messages, however. I would have expected that this was done via
showBriefly in older versions. I dont recall ever having any sort of global
message code for adding to a playlist.
-k

mherger
2005-05-27, 01:07
> on the face of it, that sounds like a great idea. I'm wondering what
> used to
> handle those messages, however. I would have expected that this was
> done via
> showBriefly in older versions. I dont recall ever having any sort of
> global message code for adding to a playlist.

Maybe it was never there? As it's not only Shoutcast I can't even blame
myself for removing it... Or am I confused because browsing music does
give that feedback, but streams don't?

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

kdf
2005-05-27, 01:51
Quoting Michael Herger <slim (AT) herger (DOT) net>:

> Maybe it was never there? As it's not only Shoutcast I can't even blame
> myself for removing it... Or am I confused because browsing music does
> give that feedback, but streams don't?

if nothing else, this sounds like a great excuse to come up with something
consistent. I haven't been able to find anywhere that may have changed, and I
dont recall a consistent feedback for radio. They all originated with
differing authors, so it's entirely believable that the UI would be different.

It almost makes sense to have the add playlist command do the display, so that
it is the same from every source. However, this would require the ability to
know that the command was triggered by a button press, rather than another
source, unless the brief display is desired even when the command comes from
the web UI.

-kdf

dean
2005-05-28, 08:37
Adding something to the playlist should have a visible feedback (any
button press that does anything should too.) ShowBriefly is probably
the right thing to use here.

Patches welcome.

On May 27, 2005, at 1:07 AM, Michael Herger wrote:

>> on the face of it, that sounds like a great idea. I'm wondering
>> what used to
>> handle those messages, however. I would have expected that this
>> was done via
>> showBriefly in older versions. I dont recall ever having any sort
>> of global message code for adding to a playlist.
>>
>
> Maybe it was never there? As it's not only Shoutcast I can't even
> blame myself for removing it... Or am I confused because browsing
> music does give that feedback, but streams don't?
>
> --
>
> Michael
>
> -----------------------------------------------------------
> Help translate SlimServer by using the
> StringEditor Plugin (http://www.herger.net/slim/)
>
>

mherger
2005-05-29, 23:39
On Sat, 28 May 2005 17:37:48 +0200, dean blackketter
<dean (AT) slimdevices (DOT) com> wrote:

> Adding something to the playlist should have a visible feedback (any
> button press that does anything should too.) ShowBriefly is probably
> the right thing to use here.

Would you leave it to the plugin's author or implement it in
Control/Command.pm (as kdf suggested)?

> Patches welcome.

Not that big problem for the plugins, I guess, but not a quicky if we want
to do it "centralised".

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

mherger
2005-05-30, 02:23
> It almost makes sense to have the add playlist command do the display,
> so that
> it is the same from every source. However, this would require the
> ability to
> know that the command was triggered by a button press, rather than
> another
> source, unless the brief display is desired even when the command comes
> from the web UI.

To make things even more complicated: sometimes we do not want to display
that information even when called from the remote. In Shoutcast there may
be several streams in one playlist for different bitrates. Currently it
starts playback of the first entry (show feedback), adding the other
entries afterwards (don't show). So we'd need one more boolean parameter
to the execute() command which would have to be checked at every call.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

mherger
2005-05-30, 02:28
> Adding something to the playlist should have a visible feedback (any
> button press that does anything should too.) ShowBriefly is probably
> the right thing to use here.
>
> Patches welcome.

Please find patches for the radio plugins (Shoutcast, RadioIO, Picks)
attached. I don't check them in yet just in case somebody wanted to come
up with a more consistant global solution.

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)