PDA

View Full Version : relative paths in m3u playlists



kirk
2005-05-20, 03:16
The server used to handle relative paths in m3u playlist files, but now it does not. Specifically, since version 6 it cannot cope with the '..' parent directory specifier. Playlist entries containing the '..' sequence fail to play.

Furthermore, attempting to view the contents of such a playlist in SlimServer causes the server to lock up and hog the CPU.

It should be possible to address audio files relative to a playlist file. This is an important feature for three reasons:
1. It has obvious advantages over absolute addressing.
2. Certain popular applications produce playlists that use relative paths.
3. My entire music collection is organised in playlists using relative paths and they no longer work!

Is this going to be fixed in the next release? Should I create a bug report in Bugzilla? Thanks for any help you can give.

Marc Sherman
2005-05-20, 06:46
kirk wrote:
> The server used to handle relative paths in m3u playlist files, but
> now it does not. Specifically, since version 6 it cannot cope with
> the '..' parent directory specifier. Playlist entries containing the
> '..' sequence fail to play.

http://bugs.slimdevices.com/show_bug.cgi?id=1282

- Marc

kdf
2005-05-20, 09:33
Quoting Marc Sherman <msherman (AT) projectile (DOT) ca>:

> kirk wrote:
> > The server used to handle relative paths in m3u playlist files, but
> > now it does not. Specifically, since version 6 it cannot cope with
> > the '..' parent directory specifier. Playlist entries containing the
> > '..' sequence fail to play.
>

truth be told....it never handled them. relative paths were the cause of song
counts jumping and the server got lucky from the rather loose handling of urls.
Now that the db requires more strict handling, that support is lost. There is
a patch submitted for bug 1506, and 1282 that should solve this, but needs
review since its a bit of an ugly hack (or maybe I'm being too hard on myself).

-kdf

kirk
2005-05-20, 09:39
Thanks Marc. I was aware that you had encountered similar problems and I have seen the patch kindly supplied by KDF. However, I don't know what to do with it, and I'm not prepared to learn programming in Perl merely in order to get my hi-fi to work properly!

I'm just want to make sure that this problem is going to be fixed in the next release.

kdf
2005-05-20, 09:40
Quoting kirk <kirk.1pca0n (AT) no-mx (DOT) forums.slimdevices.com>:

>
> Thanks Marc. I was aware that you had encountered similar problems and I
> have seen the patch kindly supplied by KDF. However, I don't know what
> to do with it, and I'm not prepared to learn programming in Perl merely
> in order to get my hi-fi to work properly!

If you are using the windows exe version, you are stuck for now.

>
> I'm just want to make sure that this problem is going to be fixed in
> the next release.

it should be. If we get close to release and that's still an open bug, I'll
likely get a lot more demanding for attention and testing :) Slim Devices has
been very focussed on getting SqueezeNetwork up and running, so I've been
patient. Were anyone aside from me who knows how to patch and can test would
confirm it, that would be enough for me to just go ahead and put it into the
6.1 nightlies.

-kdf

Philip Meyer
2005-05-20, 09:47
> Were anyone aside from me who knows how to patch and can test would
> confirm it, that would be enough for me to just go ahead and put it into the
> 6.1 nightlies.
>
Sorry, I meant to test that last night, but I never got round to it. I'm at work at the moment, but I will try to test it tonight when I get in (couple of hours).

Phil

Marc Sherman
2005-05-20, 10:55
kdf wrote:
>
> it should be. If we get close to release and that's still an open
> bug, I'll likely get a lot more demanding for attention and testing
> :) Slim Devices has been very focussed on getting SqueezeNetwork up
> and running, so I've been patient. Were anyone aside from me who
> knows how to patch and can test would confirm it, that would be
> enough for me to just go ahead and put it into the 6.1 nightlies.

I've got the skills, and a library full of .m3u's with relative paths to
test it on. However, I'm currently running a stable 5.4.1 slimserver,
and I'm afraid that hacking around with 6.1 nightlies will disturb my
tenuous grasp on spousal approval for a computer device in our living
room. :)

If no-one's stepped up to the plate by victoria day, I'll take a crack
at it.

- Marc

Philip Meyer
2005-05-21, 02:40
I have tested Kdf's relative path patch, and it seems to be working fine.

I applied the patch manually, rather than find a patch tool for windows, but the change was easy to apply - I'm confident I did it correctly.

Phil