PDA

View Full Version : [Slim-Checkins] r3147 - trunk/server/Slim/Player



mherger
2005-05-11, 10:00
> Modified:
> trunk/server/Slim/Player/Sync.pm
> Log:
> Bug: 1510
>
> Description: getting to MasterOrSelf without a client. adding an
> assert to find out where.

Oh yes, I'm getting there without a client. And then it crashes :-/

2005-05-11 18:56:51.0558 Backtrace:

frame 0: Slim::Utils::Misc::assert
(/home/mh/eclipse/SVN/Slim/Player/Sync.pm line 389)
frame 1: Slim::Player::Sync::masterOrSelf
(/home/mh/eclipse/SVN/Slim/Player/Source.pm line 951)
frame 2: Slim::Player::Source::playingSong
(/home/mh/eclipse/SVN/Slim/Player/Source.pm line 944)
frame 3: Slim::Player::Source::playingSongIndex
(/home/mh/eclipse/SVN/Slim/Web/Pages.pm line 1230)
frame 4: Slim::Web::Pages::playlist
(/home/mh/eclipse/SVN/Slim/Web/HTTP.pm line 747)
frame 5: Slim::Web::HTTP::generateHTTPResponse
(/home/mh/eclipse/SVN/Slim/Web/HTTP.pm line 668)
frame 6: Slim::Web::HTTP::processURL
(/home/mh/eclipse/SVN/Slim/Web/HTTP.pm line 532)
frame 7: Slim::Web::HTTP::processHTTP
(/home/mh/eclipse/SVN/Slim/Networking/Select.pm line 115)
frame 8: Slim::Networking::Select::select (./slimserver.pl line 624)
frame 9: main::idle (./slimserver.pl line 567)
frame 10: main::main (./slimserver.pl line 1147)

Here's the problem. /home/mh/eclipse/SVN/Slim/Player/Sync.pm, line 389:

379 # returns the master if it's a slave, otherwise returns undef
380 sub isSlave {
381 my $client = shift;
382 return undef unless $client;
383 return $client->master;
384 }
385
386 sub masterOrSelf {
387 my $client = shift;
388
389 assert($client);
390
391 return $client->master || $client;
392 }

--

Michael

-----------------------------------------------------------
Help translate SlimServer by using the
StringEditor Plugin (http://www.herger.net/slim/)

kdf
2005-05-11, 10:07
Quoting Michael Herger <slim (AT) herger (DOT) net>:

> > Modified:
> > trunk/server/Slim/Player/Sync.pm
> > Log:
> > Bug: 1510
> >
> > Description: getting to MasterOrSelf without a client. adding an
> > assert to find out where.
>
> Oh yes, I'm getting there without a client. And then it crashes :-/
>
ok...how are you getting there, and what rev are you running to do so?

-kdf