PDA

View Full Version : Browsing issues



dbls
2005-01-23, 12:15
When I use Browse Music Folder and navigate to an album
that has a period in the title, the link at the top of the
frame omits everything after the period; for example, if I
go to Adrain Belew/Mr. Music Head, the links show as:

Home / Music Folder / Adrian Belew / Mr

-:- dbls

kdf
2005-01-24, 19:39
Quoting dbls <dbls (AT) comcast (DOT) net>:

> When I use Browse Music Folder and navigate to an album
> that has a period in the title, the link at the top of the
> frame omits everything after the period; for example, if I
> go to Adrain Belew/Mr. Music Head, the links show as:
>
> Home / Music Folder / Adrian Belew / Mr
>
> -:- dbls


This is possibly due to the standardTitle() function removing extensions
(everything past the last '.').

To confirm, try turning on d_info and looking for "Plain title for:" in the log.

-kdf

dbls
2005-01-25, 06:50
Quoting kdf:

> Quoting dbls <dbls (AT) comcast (DOT) net>:
>
>> When I use Browse Music Folder and navigate to an album
>> that has a period in the title, the link at the top of the
>> frame omits everything after the period; for example, if I
>> go to Adrain Belew/Mr. Music Head, the links show as:
>>
>> Home / Music Folder / Adrian Belew / Mr
>>
>> -:- dbls
>
>
> This is possibly due to the standardTitle() function removing extensions
> (everything past the last '.').
>
> To confirm, try turning on d_info and looking for "Plain title for:" in the log.
>
> -kdf

Yep:

2005-01-25 08:09:11.5008 Plain title for: file:////Gateway400/Music/Mr.%20Music%20Head
2005-01-25 08:09:11.5023 is Mr

Perhaps the standardTitle() function should either ignore
periods that precede spaces in the file name, or could be
passed a parameter indicating that the name is a folder,
and hence has no extension.

Off-topic aside: Why is the server making requests for
MOODLOGIC_SONG_MIXABLE? It may use a trivial amount of
processing to make the request, but wouldn't it make sense
to avoid this check if MoodLogic isn't in use, which I
assume is the typical case?

-:- dbls

kdf
2005-01-25, 13:29
Quoting dbls <dbls (AT) comcast (DOT) net>:

> Quoting kdf:
>
> > Quoting dbls <dbls (AT) comcast (DOT) net>:
> >
> >> When I use Browse Music Folder and navigate to an album
> >> that has a period in the title, the link at the top of the
> >> frame omits everything after the period; for example, if I
> >> go to Adrain Belew/Mr. Music Head, the links show as:
> >>
> >> Home / Music Folder / Adrian Belew / Mr
> >>
> >> -:- dbls
> >
> >
> > This is possibly due to the standardTitle() function removing extensions
> > (everything past the last '.').
> >
> > To confirm, try turning on d_info and looking for "Plain title for:" in the
> log.
> >
> > -kdf
>
> Yep:
>
> 2005-01-25 08:09:11.5008 Plain title for:
> file:////Gateway400/Music/Mr.%20Music%20Head
> 2005-01-25 08:09:11.5023 is Mr
>
> Perhaps the standardTitle() function should either ignore
> periods that precede spaces in the file name, or could be
> passed a parameter indicating that the name is a folder,
> and hence has no extension.

sure...but then you get someone else posting, furious that their folders with
extensions are showing too much info ;)

standardTitle could improve on what it is currently doing, however.

> Off-topic aside: Why is the server making requests for
> MOODLOGIC_SONG_MIXABLE? It may use a trivial amount of
> processing to make the request, but wouldn't it make sense
> to avoid this check if MoodLogic isn't in use, which I
> assume is the typical case?

yes, it would make a lot of sense :)
stripping a lot of the import stuff into plugins is something I'm working on.
stay tuned (patiently ;)

Currently, for the 5.4.1 stuff its still VERY little overhead but there are
other things that come up with imorters, even if they arent being used. As it
stands, the cost of checking if moodlogic is in use each time is about the same
as just checking for the MIXABLE info.

-kdf