PDA

View Full Version : Amazon Image package



Jack Coates
2005-01-08, 16:07
I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
anything, but it was fun :)

RPM is here:
http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm

The spec file is in the same directory. Built on Mandrake 10.1, should
work on other RPM-based Linuces with a --no-deps.

--
Jack at Monkeynoodle dot Org: It's a Scientific Venture...
Riding the Emergency Third Rail Power Trip since 1996!

Jack Coates
2005-01-08, 16:09
Jack Coates wrote:
> I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
> for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
> anything, but it was fun :)
>
> RPM is here:
> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>
> The spec file is in the same directory. Built on Mandrake 10.1, should
> work on other RPM-based Linuces with a --no-deps.
>

oh yeah, the package is signed; to keep urpmi from complaining, you can
import my signature:

wget http://www.monkeynoodle.org/tmp/jack_coates.asc
sudo rpm --import jack_coates.asc

--
Jack at Monkeynoodle dot Org: It's a Scientific Venture...
Riding the Emergency Third Rail Power Trip since 1996!

Victor Brilon
2005-01-08, 16:21
Thanks Jack for doing this. I hadn't even thought about making an RPM of it.

Hopefully, the 1.5 final version will be ready to go this weekend and
I'll sync up with you to get the RPM updated.

Victor

Jack Coates wrote:
> I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
> for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
> anything, but it was fun :)
>
> RPM is here:
> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>
> The spec file is in the same directory. Built on Mandrake 10.1, should
> work on other RPM-based Linuces with a --no-deps.
>

Avi Schwartz
2005-01-08, 19:15
Jack Coates wrote:

> Jack Coates wrote:
>
>> I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
>> for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
>> anything, but it was fun :)
>>
>> RPM is here:
>> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>>
>> The spec file is in the same directory. Built on Mandrake 10.1,
>> should work on other RPM-based Linuces with a --no-deps.
>>
>
> oh yeah, the package is signed; to keep urpmi from complaining, you
> can import my signature:
>
> wget http://www.monkeynoodle.org/tmp/jack_coates.asc
> sudo rpm --import jack_coates.asc
>
Jack,


This is probably not your doing, but rather a bug in the program, but I
received the following error when running make_cover.pl:

Can't use string ("1") as a HASH ref while "strict refs" in use at
../make_cover.pl line 113.


I also had a bunch of warnings:

Use of uninitialized value in string ne at
/usr/local/slimserver//ReadTag.pm line 54.

as well as "has an unknown extension type" which I assume are the m4a
files I have (luckily only a few of these type).

Avi

Jack Coates
2005-01-08, 20:55
Avi Schwartz wrote:
> Jack Coates wrote:
>
>> Jack Coates wrote:
>>
>>> I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
>>> for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
>>> anything, but it was fun :)
>>>
>>> RPM is here:
>>> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>>>
>>> The spec file is in the same directory. Built on Mandrake 10.1,
>>> should work on other RPM-based Linuces with a --no-deps.
>>>
>>
>> oh yeah, the package is signed; to keep urpmi from complaining, you
>> can import my signature:
>>
>> wget http://www.monkeynoodle.org/tmp/jack_coates.asc
>> sudo rpm --import jack_coates.asc
>>
> Jack,
>
>
> This is probably not your doing, but rather a bug in the program, but I
> received the following error when running make_cover.pl:
>
> Can't use string ("1") as a HASH ref while "strict refs" in use at
> ./make_cover.pl line 113.
>
>
> I also had a bunch of warnings:
>
> Use of uninitialized value in string ne at
> /usr/local/slimserver//ReadTag.pm line 54.
>
> as well as "has an unknown extension type" which I assume are the m4a
> files I have (luckily only a few of these type).
>
> Avi

yeah, that's not mine. I get the uninitialized value errors too. The
hash ref error kills it, right? If you turn on debug, it will give you a
track name just before it errors out. Can you post the output of running
id3tool on that track?

--
Jack at Monkeynoodle dot Org: It's a Scientific Venture...
Riding the Emergency Third Rail Power Trip since 1996!

Avi Schwartz
2005-01-08, 21:40
Jack Coates wrote:

> Avi Schwartz wrote:
>
>>> Jack Coates wrote:
>>>
>>>> I've packaged Victor Brilon's Amazon Image utility version
>>>> 1.5.1beta2 for Mandrake Linux 10.1. Not like it's hugely necessary
>>>> to do so or anything, but it was fun :)
>>>>
>>>> RPM is here:
>>>> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>>>>
>>>>
>>>> The spec file is in the same directory. Built on Mandrake 10.1,
>>>> should work on other RPM-based Linuces with a --no-deps.
>>>>
>>>
>> This is probably not your doing, but rather a bug in the program, but
>> I received the following error when running make_cover.pl:
>>
>> Can't use string ("1") as a HASH ref while "strict refs" in use at
>> ./make_cover.pl line 113.
>>
>>
>> I also had a bunch of warnings:
>>
>> Use of uninitialized value in string ne at
>> /usr/local/slimserver//ReadTag.pm line 54.
>>
>> as well as "has an unknown extension type" which I assume are the m4a
>> files I have (luckily only a few of these type).
>>
>>
>
> yeah, that's not mine. I get the uninitialized value errors too. The
> hash ref error kills it, right? If you turn on debug, it will give you
> a track name just before it errors out. Can you post the output of
> running id3tool on that track?
>
The debug pointed me to the right place. It seems that iTunes (my music
library originated from iTunes) left some droppings around. I found two
files that had the .mp3 extension but were 2K in size and while id3tool
did not find any tags in these files, file claimed that they are "MP3
file with ID3 version 2.2.0 tag". So it seems that the files in question
were corrupt. I moved these files out of the way and now the program
continues the scan. I can mail the files to anyone who is interested in
taking a look at them to determine how to trap the error so that
make_cover will not bomb.

Now I have a new problem. I have one Greek CD. When I ripped it, it got
the track info from CDDB properly although in Greek. Since I cannot read
Greek (it's Greek to me :-) and the CD cover is also in Greek, I left
the track info as is, i.e. in Greek. Looks like this breaks the program.
It dies with the following information:

Now looking in: /var/music/Giannis Kotsiras/Μο?νο ε?να Φιλι?
This album is not a Various artists album
Using this track to test: ???? ??? ????
Debug is turned on
Threshold is set to: 0.6
Doing search for ???? ??? ???? Giannis Kotsiras
Looking for images sized: Large

Testing against: Young Ginns - Young Ginns
Quantifier follows nothing in regex; marked by <-- HERE in m/? <-- HERE
??? ???????/ at /usr/local/slimserver//AmazonMusicImage.pm line 135.

Avi

--
Avi Schwartz
http://public.xdi.org/=avi.schwartz

When you have robbed a man of everything, he is no longer in your power. He is free again.

-- Alexander Solzhenitsyn

Victor Brilon
2005-01-08, 21:41
>> Can't use string ("1") as a HASH ref while "strict refs" in use at
>> ./make_cover.pl line 113.
>>
>>
>> I also had a bunch of warnings:
>>
>> Use of uninitialized value in string ne at
>> /usr/local/slimserver//ReadTag.pm line 54.
>>
>> as well as "has an unknown extension type" which I assume are the m4a
>> files I have (luckily only a few of these type).
>>

This is why this version is still in beta :)

I am amazed at the variations in music files that other users have found
that cause this code to blow up. But this is good since it means we can
make the code smarter for future users.

I've uploaded a new version a little while back with some very minor
changes in it, but did not update the version number. Can you download
it please and try again? If you're still getting the error, please run
with the -d option and send me the output of which file it blows up on.

Thanks,
Victor

Jack Coates
2005-01-08, 21:44
Victor Brilon wrote:
>>> Can't use string ("1") as a HASH ref while "strict refs" in use at
>>> ./make_cover.pl line 113.
>>>
>>>
>>> I also had a bunch of warnings:
>>>
>>> Use of uninitialized value in string ne at
>>> /usr/local/slimserver//ReadTag.pm line 54.
>>>
>>> as well as "has an unknown extension type" which I assume are the
>>> m4a files I have (luckily only a few of these type).
>>>
>
> This is why this version is still in beta :)
>
> I am amazed at the variations in music files that other users have found
> that cause this code to blow up. But this is good since it means we can
> make the code smarter for future users.
>
> I've uploaded a new version a little while back with some very minor
> changes in it, but did not update the version number. Can you download
> it please and try again? If you're still getting the error, please run
> with the -d option and send me the output of which file it blows up on.
>
> Thanks,
> Victor

how far back? I built the RPM from a version I downloaded yesterday.

--
Jack at Monkeynoodle dot Org: It's a Scientific Venture...
Riding the Emergency Third Rail Power Trip since 1996!

Avi Schwartz
2005-01-08, 21:48
Victor Brilon wrote:

>>> Can't use string ("1") as a HASH ref while "strict refs" in use at
>>> ./make_cover.pl line 113.
>>>
>>>
>>> I also had a bunch of warnings:
>>>
>>> Use of uninitialized value in string ne at
>>> /usr/local/slimserver//ReadTag.pm line 54.
>>>
>>> as well as "has an unknown extension type" which I assume are the
>>> m4a files I have (luckily only a few of these type).
>>>
>
> This is why this version is still in beta :)
>
> I am amazed at the variations in music files that other users have
> found that cause this code to blow up. But this is good since it means
> we can make the code smarter for future users.
>
> I've uploaded a new version a little while back with some very minor
> changes in it, but did not update the version number. Can you download
> it please and try again? If you're still getting the error, please run
> with the -d option and send me the output of which file it blows up on.

And I more then happy to help with the testing. I pretty good in
breaking programs; I just wish was was as good in fixing them :-)

Avi

Victor Brilon
2005-01-08, 21:51
Jack Coates wrote:

> how far back? I built the RPM from a version I downloaded yesterday.

Crap. Now I'd really like to know what broke that code. I thought I
fixed that one case :/

Victor

Victor Brilon
2005-01-08, 21:55
Avi Schwartz wrote:

> The debug pointed me to the right place. It seems that iTunes (my music
> library originated from iTunes) left some droppings around. I found two
> files that had the .mp3 extension but were 2K in size and while id3tool
> did not find any tags in these files, file claimed that they are "MP3
> file with ID3 version 2.2.0 tag". So it seems that the files in question
> were corrupt. I moved these files out of the way and now the program
> continues the scan. I can mail the files to anyone who is interested in
> taking a look at them to determine how to trap the error so that
> make_cover will not bomb.

Excellent! I am fixing the code now to be smarter about files claiming
to be something they're not. Good to know that this can heppen.

> Now I have a new problem. I have one Greek CD. When I ripped it, it got
> the track info from CDDB properly although in Greek. Since I cannot read
> Greek (it's Greek to me :-) and the CD cover is also in Greek, I left
> the track info as is, i.e. in Greek. Looks like this breaks the program.
> It dies with the following information:
>
> Now looking in: /var/music/Giannis Kotsiras/Μο?νο ε?να Φιλι?
> This album is not a Various artists album
> Using this track to test: ???? ??? ????
> Debug is turned on
> Threshold is set to: 0.6
> Doing search for ???? ??? ???? Giannis Kotsiras
> Looking for images sized: Large
>
> Testing against: Young Ginns - Young Ginns
> Quantifier follows nothing in regex; marked by <-- HERE in m/? <-- HERE
> ??? ???????/ at /usr/local/slimserver//AmazonMusicImage.pm line 135.

Two things going on here:
UTF-8 searches are horribly broken right now, and the regexps do not do
any escpaing of special characters (like ?& and such). Both fixes are on
my to do list, although to be honest I am not feeling very confident
about the UTF-8 fixes right now due to weirdness with the XML parser in
the SOAP package.

Victor

Avi Schwartz
2005-01-08, 22:14
Victor Brilon wrote:

> Avi Schwartz wrote:
>
>> The debug pointed me to the right place. It seems that iTunes (my
>> music library originated from iTunes) left some droppings around. I
>> found two files that had the .mp3 extension but were 2K in size and
>> while id3tool did not find any tags in these files, file claimed that
>> they are "MP3 file with ID3 version 2.2.0 tag". So it seems that the
>> files in question were corrupt. I moved these files out of the way
>> and now the program continues the scan. I can mail the files to
>> anyone who is interested in taking a look at them to determine how to
>> trap the error so that make_cover will not bomb.
>
>
> Excellent! I am fixing the code now to be smarter about files claiming
> to be something they're not. Good to know that this can heppen.
>
>> Now I have a new problem. I have one Greek CD. When I ripped it, it
>> got the track info from CDDB properly although in Greek. Since I
>> cannot read Greek (it's Greek to me :-) and the CD cover is also in
>> Greek, I left the track info as is, i.e. in Greek. Looks like this
>> breaks the program. It dies with the following information:
>>
>> Now looking in: /var/music/Giannis Kotsiras/Μο?νο ε?να Φιλι?
>> This album is not a Various artists album
>> Using this track to test: ???? ??? ????
>> Debug is turned on
>> Threshold is set to: 0.6
>> Doing search for ???? ??? ???? Giannis Kotsiras
>> Looking for images sized: Large
>>
>> Testing against: Young Ginns - Young Ginns
>> Quantifier follows nothing in regex; marked by <-- HERE in m/? <--
>> HERE ??? ???????/ at /usr/local/slimserver//AmazonMusicImage.pm line
>> 135.
>
>
> Two things going on here:
>
> UTF-8 searches are horribly broken right now, and the regexps do not
> do any escpaing of special characters (like ?& and such). Both fixes
> are on my to do list, although to be honest I am not feeling very
> confident about the UTF-8 fixes right now due to weirdness with the
> XML parser in the SOAP package.
>
Looks like I got lucky. I checked CDDB again and this time there was a
non-Greek version of the track names. This should clear this problem.

Avi

--
Avi Schwartz
http://public.xdi.org/=avi.schwartz

When you have robbed a man of everything, he is no longer in your power. He is free again.

-- Alexander Solzhenitsyn

Avi Schwartz
2005-01-09, 10:13
Jack Coates wrote:

> Jack Coates wrote:
>
>> I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
>> for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
>> anything, but it was fun :)
>>
>> RPM is here:
>> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>>
>> The spec file is in the same directory. Built on Mandrake 10.1,
>> should work on other RPM-based Linuces with a --no-deps.
>>
>
> oh yeah, the package is signed; to keep urpmi from complaining, you
> can import my signature:
>
> wget http://www.monkeynoodle.org/tmp/jack_coates.asc
> sudo rpm --import jack_coates.asc

Jack,

May I suggest that instead of adding an entry into crontab that you
create a file in /etc/cron.d. This will keep the system cron entries
separate from the non-system ones?

Avi

Jack Coates
2005-01-09, 11:30
Avi Schwartz wrote:
> Jack Coates wrote:
>
>> Jack Coates wrote:
>>
>>> I've packaged Victor Brilon's Amazon Image utility version 1.5.1beta2
>>> for Mandrake Linux 10.1. Not like it's hugely necessary to do so or
>>> anything, but it was fun :)
>>>
>>> RPM is here:
>>> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>>>
>>> The spec file is in the same directory. Built on Mandrake 10.1,
>>> should work on other RPM-based Linuces with a --no-deps.
>>>
>>
>> oh yeah, the package is signed; to keep urpmi from complaining, you
>> can import my signature:
>>
>> wget http://www.monkeynoodle.org/tmp/jack_coates.asc
>> sudo rpm --import jack_coates.asc
>
>
> Jack,
>
> May I suggest that instead of adding an entry into crontab that you
> create a file in /etc/cron.d. This will keep the system cron entries
> separate from the non-system ones?
>
> Avi

yeah, that was definitely a shortcut. I'm also thinking about using the
slimserver user account, on the assumption that slimserver's user
account has write access to the music share (may not be a good
assumption). I don't like running network-using scripts as root, though
the danger is obviously pretty low here.

--
Jack at Monkeynoodle dot Org: It's a Scientific Venture...
Riding the Emergency Third Rail Power Trip since 1996!

Avi Schwartz
2005-01-09, 11:43
Jack Coates wrote:

> Avi Schwartz wrote:
>
>> Jack Coates wrote:
>>
>>> Jack Coates wrote:
>>>
>>>> I've packaged Victor Brilon's Amazon Image utility version
>>>> 1.5.1beta2 for Mandrake Linux 10.1. Not like it's hugely necessary
>>>> to do so or anything, but it was fun :)
>>>>
>>>> RPM is here:
>>>> http://www.monkeynoodle.org/tmp/amazon_image-1.5.1beta2-1mdk.noarch.rpm
>>>>
>>>>
>>>> The spec file is in the same directory. Built on Mandrake 10.1,
>>>> should work on other RPM-based Linuces with a --no-deps.
>>>>
>>>
>>> oh yeah, the package is signed; to keep urpmi from complaining, you
>>> can import my signature:
>>>
>>> wget http://www.monkeynoodle.org/tmp/jack_coates.asc
>>> sudo rpm --import jack_coates.asc
>>
>>
>>
>> Jack,
>>
>> May I suggest that instead of adding an entry into crontab that you
>> create a file in /etc/cron.d. This will keep the system cron entries
>> separate from the non-system ones?
>>
>> Avi
>
>
> yeah, that was definitely a shortcut. I'm also thinking about using
> the slimserver user account, on the assumption that slimserver's user
> account has write access to the music share (may not be a good
> assumption). I don't like running network-using scripts as root,
> though the danger is obviously pretty low here.
>
In my case the slimserver user account is not the owner of the music
directory since I am rsyncing the iTunes directory from the mac to the
mdk box. But this is not a big deal since I can change the ownership of
the directory. I am also not too worried about security since I have a
dedicated machine for the slimserver which is internal and behind the
firewall.

Avi

--
Avi Schwartz
http://public.xdi.org/=avi.schwartz

When you have robbed a man of everything, he is no longer in your power. He is free again.

-- Alexander Solzhenitsyn

Jack Coates
2005-01-09, 11:53
Avi Schwartz wrote:
....
>>
>> yeah, that was definitely a shortcut. I'm also thinking about using
>> the slimserver user account, on the assumption that slimserver's user
>> account has write access to the music share (may not be a good
>> assumption). I don't like running network-using scripts as root,
>> though the danger is obviously pretty low here.
>>
> In my case the slimserver user account is not the owner of the music
> directory since I am rsyncing the iTunes directory from the mac to the
> mdk box. But this is not a big deal since I can change the ownership of
> the directory. I am also not too worried about security since I have a
> dedicated machine for the slimserver which is internal and behind the
> firewall.
>
> Avi
>

groups are good for this sort of thing.

--
Jack at Monkeynoodle dot Org: It's a Scientific Venture...
Riding the Emergency Third Rail Power Trip since 1996!