PDA

View Full Version : Live365



Mark Sayers
2004-11-25, 12:43
Thanks for the prompt response Jim, but no good Im afraid...


Firstly I dont have the text below at line 546, and the only thing I have
found that is similar is:

$response =~ /^HTTP\/1.1 302 Found/ or return undef;

At line 346.


Sorry if I am being thick. Will it be in the latest nightly build?

Cheers for your continues help mate.

cheers


> Got it. The plugin is looking for a HTTP/1.1 response "302 Found" not
> the 1.0 response "302 Moved Temporarily"
>
> I just emailed Vidur a fix to be checked in. If you feel like editing
> yourself, it's a one line change:
>
> In Plugins/Live365.pm, line 546 was:
> $response =~ /^HTTP\/1.1 302 Found/ or do {
>
> ...and is now:
> $response =~ /^HTTP\/1\.\d 302/ or do {
>
> Cheers,
> Jim

Jim
2004-11-25, 17:30
You just missed the update that printed an debugging message if the
response didn't match. In case we need to do more debugging, I suggest
you get the latest nightly.

If you want instant gratification, you can see the changes on the lines
I quoted below. It changes the test to match 1.1 or 1.0 (or 1.2, 1.3,
etc., but that's not important) and stops matching at the "302" response
from Live365.

For your version of the plugin, it'll look like:
$response =~ /^HTTP\/1\.\d 302/ or return undef;

Jim


Mark Sayers wrote:
> Thanks for the prompt response Jim, but no good Im afraid...
>
>
> Firstly I dont have the text below at line 546, and the only thing I
> have found that is similar is:
>
> $response =~ /^HTTP\/1.1 302 Found/ or return undef;
>
> At line 346.
>
>
> Sorry if I am being thick. Will it be in the latest nightly build?
>
> Cheers for your continues help mate.
>
> cheers
>
>
>> Got it. The plugin is looking for a HTTP/1.1 response "302 Found" not
>> the 1.0 response "302 Moved Temporarily"
>>
>> I just emailed Vidur a fix to be checked in. If you feel like editing
>> yourself, it's a one line change:
>>
>> In Plugins/Live365.pm, line 546 was:
>> $response =~ /^HTTP\/1.1 302 Found/ or do {
>>
>> ...and is now:
>> $response =~ /^HTTP\/1\.\d 302/ or do {
>>
>> Cheers,
>> Jim
>
>
> ------------------------------------------------------------------------
>
>

Jim
2004-11-25, 17:45
This is a different problem entirely. It's acting like the live365
protocol handler isn't registered...

I don't have any idea off the top of my head. It'll take some research.

Jim


Roger Mitchell wrote:
> Same for me! I have just downloaded the build of the 25th (today's) and
> the problem has changed. Instead of timing out to "stopped", I now time
> out to "Now Playing", "Nothing". Here is the log within plugins
> debugging selected.
>
> Thanks for your dedication Jim.
>
> Best regards
> Roger, Newbury, UK
>
>
> 2004-11-25 22:41:30.9912 Live365.ChannelMode URL: live365://www.live365.com/play/robb2ins?sessionid=hitoweruk:58gSou0zrXMSM
> 2004-11-25 22:41:30.9916 Non-URL passed to updateCacheEntry::info (live365://www.live365.com/play/robb2ins?sessionid=hitoweruk:58gSou0zrXMSM)
> 2004-11-25 22:41:30.9923 Backtrace:
>
> frame 0: Slim::Music::Info::updateCacheEntry (/PerlApp/Slim/Music/Info.pm line 937)
> frame 1: Slim::Music::Info::setContentType (C:/PROGRA~1/SLIMSE~1/server/Plugins/Live365.pm line 739)
> frame 2: Plugins::Live365::playOrAddCurrentStation (C:/PROGRA~1/SLIMSE~1/server/Plugins/Live365.pm line 1195)
> frame 3: Plugins::Live365::__ANON__ (/PerlApp/Slim/Hardware/IR.pm line 546)
> frame 4: Slim::Hardware::IR::executeButton (/PerlApp/Slim/Control/Command.pm line 209)
> frame 5: Slim::Control::Command::execute (/PerlApp/Slim/Hardware/IR.pm line 570)
> frame 6: Slim::Hardware::IR::processCode (/PerlApp/Slim/Hardware/IR.pm line 429)
> frame 7: Slim::Hardware::IR::releaseCode (/PerlApp/Slim/Hardware/IR.pm line 327)
> frame 8: Slim::Hardware::IR::checkRelease (/PerlApp/Slim/Utils/Timers.pm line 52)
> frame 9: Slim::Utils::Timers::checkTimers (slimserver.pl line 426)
> frame 10: main::idle (slimserver.pl line 396)
> frame 11: main::main (slimserver.pl line 61)
> frame 12: PerlSvc::Interactive (perlsvc line 1205)
> frame 13: PerlSvc::_interactive (slimserver.pl line 0)
> frame 14: (eval) (slimserver.pl line 0)
>
> 2004-11-25 22:41:30.9955 Non-URL passed to updateCacheEntry::info (live365://www.live365.com/play/robb2ins?sessionid=hitoweruk:58gSou0zrXMSM)
> 2004-11-25 22:41:30.9961 Backtrace:
>
> frame 0: Slim::Music::Info::updateCacheEntry (/PerlApp/Slim/Music/Info.pm line 951)
> frame 1: Slim::Music::Info::setTitle (C:/PROGRA~1/SLIMSE~1/server/Plugins/Live365.pm line 740)
> frame 2: Plugins::Live365::playOrAddCurrentStation (C:/PROGRA~1/SLIMSE~1/server/Plugins/Live365.pm line 1195)
> frame 3: Plugins::Live365::__ANON__ (/PerlApp/Slim/Hardware/IR.pm line 546)
> frame 4: Slim::Hardware::IR::executeButton (/PerlApp/Slim/Control/Command.pm line 209)
> frame 5: Slim::Control::Command::execute (/PerlApp/Slim/Hardware/IR.pm line 570)
> frame 6: Slim::Hardware::IR::processCode (/PerlApp/Slim/Hardware/IR.pm line 429)
> frame 7: Slim::Hardware::IR::releaseCode (/PerlApp/Slim/Hardware/IR.pm line 327)
> frame 8: Slim::Hardware::IR::checkRelease (/PerlApp/Slim/Utils/Timers.pm line 52)
> frame 9: Slim::Utils::Timers::checkTimers (slimserver.pl line 426)
> frame 10: main::idle (slimserver.pl line 396)
> frame 11: main::main (slimserver.pl line 61)
> frame 12: PerlSvc::Interactive (perlsvc line 1205)
> frame 13: PerlSvc::_interactive (slimserver.pl line 0)
> frame 14: (eval) (slimserver.pl line 0)
>
>
>
> ------------------------------------------------------------------------
> *From:*
> discuss-bounces (AT) lists (DOT) slimdevices.com
> [mailto:discuss-bounces (AT) lists (DOT) slimdevices.com]
> *On Behalf Of *Mark Sayers
> *Sent:* 25 November 2004 19:43
> *To:* discuss (AT) lists (DOT) slimdevices.com
> *Subject:* [slim] Live365
>
> Thanks for the prompt response Jim, but no good Im afraid...
>
>
> Firstly I dont have the text below at line 546, and the only thing I
> have found that is similar is:
>
> $response =~ /^HTTP\/1.1 302 Found/ or return undef;
>
> At line 346.
>
>
> Sorry if I am being thick. Will it be in the latest nightly build?
>
> Cheers for your continues help mate.
>
> cheers
>
>
>> Got it. The plugin is looking for a HTTP/1.1 response "302 Found" not
>> the 1.0 response "302 Moved Temporarily"
>>
>> I just emailed Vidur a fix to be checked in. If you feel like editing
>> yourself, it's a one line change:
>>
>> In Plugins/Live365.pm, line 546 was:
>> $response =~ /^HTTP\/1.1 302 Found/ or do {
>>
>> ...and is now:
>> $response =~ /^HTTP\/1\.\d 302/ or do {

kdf
2004-11-25, 20:34
Quoting Jim <jim1128 (AT) comcast (DOT) net>:

> This is a different problem entirely. It's acting like the live365
> protocol handler isn't registered...
>
> I don't have any idea off the top of my head. It'll take some research.

Jim,

take a look at Slim::Music::Info::isURL() and see if that is the right function
to be using. It was changed as part of the musicmagic patch applied last
night, and as can happen with big patches, I'm not sure if that was intended to
be changed.
-kdf

Jim
2004-11-26, 09:48
kdf wrote:
> Quoting Jim <jim1128 (AT) comcast (DOT) net>:
>
>
>>This is a different problem entirely. It's acting like the live365
>>protocol handler isn't registered...
>>
>>I don't have any idea off the top of my head. It'll take some research.
>
>
> Jim,
>
> take a look at Slim::Music::Info::isURL() and see if that is the right function
> to be using. It was changed as part of the musicmagic patch applied last
> night, and as can happen with big patches, I'm not sure if that was intended to
> be changed.

I looked at isURL last night, the regex looks good to my eye. "live365"
should exist in %Slim::Player::Source::protocolHandlers since I call
Slim::Player::Source::registerProtocolHandler().

I haven't gotten around to really debugging it yet, so it could be any
one of a zillion things.

Jim