Significant changes to transcoding framework

[britboy]

Originally Posted by IceFusion

excellent. look forward to testing it, though I won't be able to get to it until Thursday...

can you help me get a jumpstart on my my custom converter defs? (assume convert.conf will contain updated defs, particularly for [alac]?)

mov flc * *
[faad] -w -f 2 $FILE$ | [flac] -cs --totally-silent --compression-level-0 --endian little --sign signed --channels 2 --bps 16 --sample-rate 44100 -

mov wav * *
[faad] -w -f 2 $FILE$

I was able to get everything up and running with these:

# Transcoding for AAC files.
mov flc * *
# F
[faad] -w -f 2 $FILE$ | [flac] -cs --totally-silent --compression-level-0 --endian little --sign signed --channels 2 --bps 16 --sample-rate 44100 -

mov mp3 * *
# FB:{BITRATE=-B %B}
[faad] -w -f 2 $FILE$ | [lame] --resample 44100 --silent -q $QUALITY$ $BITRATE$ -r - -

mov wav * *
# F
[faad] -w -f 2 $FILE$

[pardsbane]

Originally Posted by britboy

I was able to get everything up and running with these:

# Transcoding for AAC files.
mov flc * *
# F
[faad] -w -f 2 $FILE$ | [flac] -cs --totally-silent --compression-level-0 --endian little --sign signed --channels 2 --bps 16 --sample-rate 44100 -

mov mp3 * *
# FB:{BITRATE=-B %B}
[faad] -w -f 2 $FILE$ | [lame] --resample 44100 --silent -q $QUALITY$ $BITRATE$ -r - -

mov wav * *
# F
[faad] -w -f 2 $FILE$

I can confirm these settings work. Make sure you have the white space before the #'s.

[Klaas]

I am using the custom-convert.conf for the BruteFirDRC Plugin. I got one problem with the new syntax. I need to add the bitrate to the command line so that flac files with different bitrates can be transcoded correctly, but it looks like only the first occurence of a variable is replaced. I am using the BITRATE two times but only the first one is replaced.


flc flc * 00:04:20:06:b4:65
# F:{BITRATE=%d}
[flac] -dcs --force-raw-format --endian=little --sign=signed -- $FILE$ | /usr/share/squeezecenter/Plugins/BrutefirDrc/brutefirwrapper 00:04:20:06:b4:65 /etc/squeezecenter/BrutefirDrc/settings/filter-00_04_20_06_b4_65 $BITRATE$ | [flac] -cs -0 --totally-silent --endian=little --sign=signed --channels=2 --bps=24 --sample-rate=$BITRATE$ -

debug output from server.log (the last BITRATE at the end is not replaced):
[08-12-12 17:23:46.1510] Slim::Player::TranscodingHelper::checkBin (237) Found command: [flac] -dcs --force-raw-format --endian=little --sign=signed -- $FILE$ | /usr/share/squeezecenter/Plugins/BrutefirDrc/brutefirwrapper 00:04:20:06:b4:65 /etc/squeezecenter/BrutefirDrc/settings/filter-00_04_20_06_b4_65 $BITRATE$ | [flac] -cs -0 --totally-silent --endian=little --sign=signed --channels=2 --bps=24 --sample-rate=$BITRATE$ -
[08-12-12 17:23:46.1513] Slim::Player::TranscodingHelper::getConvertCommand 2 (454) Matched: flc->flc via: [flac] -dcs --force-raw-format --endian=little --sign=signed -- $FILE$ | /usr/share/squeezecenter/Plugins/BrutefirDrc/brutefirwrapper 00:04:20:06:b4:65 /etc/squeezecenter/BrutefirDrc/settings/filter-00_04_20_06_b4_65 $BITRATE$ | [flac] -cs -0 --totally-silent --endian=little --sign=signed --channels=2 --bps=24 --sample-rate=$BITRATE$ -
[08-12-12 17:23:46.1515] Slim::Player::Song:pen (340) Transcoder: streamMode=F, streamformat=flc
[08-12-12 17:23:46.1526] Slim::Player::TranscodingHelper::tokenizeConvertCo mmand2 (557) Using command for conversion: "/usr/bin/flac" -dcs --force-raw-format --endian=little --sign=signed -- "/music/slimserver/flac/Bands/Agalloch/The_White/02.Birch_Black.flac" | /usr/share/squeezecenter/Plugins/BrutefirDrc/brutefirwrapper 00:04:20:06:b4:65 /etc/squeezecenter/BrutefirDrc/settings/filter-00_04_20_06_b4_65 44100 | "/usr/bin/flac" -cs -0 --totally-silent --endian=little --sign=signed --channels=2 --bps=24 --sample-rate=$BITRATE$ -
[08-12-12 17:23:46.1528] Slim::Player::Song:pen (457) Tokenized command "/usr/bin/flac" -dcs --force-raw-format --endian=little --sign=signed -- "/music/slimserver/flac/Bands/Agalloch/The_White/02.Birch_Black.flac
" | /usr/share/squeezecenter/Plugins/BrutefirDrc/brutefirwrapper 00:04:20:06:b4:65 /etc/squeezecenter/BrutefirDrc/settings/filter-00_04_20_06_b4_65 44100 | "/usr/bin/flac" -cs -0 --totally-silent --endian=little --sign=signed --channels=2 --bps=24 --sample-rate=$BITRATE$ -
[08-12-12 17:23:46.2558] Slim::Player::SongStreamController::new (32) live=1


Do I miss something or is this a bug? With SqueezeCenter 7.2.x I used the RATE and the variable was replaced n-times.

Regards Klaas

[awy]

I'm not sure that I would classify it as a bug, just an omitted piece of functionality.

If you want to hack up a solution yourself, then just add a g to the variable substitution in TranscodingHelper.pm:

	foreach (keys %subs) {
		$command =~ s/\$$_\$/$subs{$_}/;
	}

with

	foreach (keys %subs) {
		$command =~ s/\$$_\$/$subs{$_}/g;
	}

You could also file an enhancement request.

Alan.

[Klaas]

I created a bug for this in the tracking tool:
http://bugs.slimdevices.com/show_bug.cgi?id=10814

[Klaas]

Somehow the transcoding does not work as expected, so I reopened the bug, see there for more information. Maybe it should be a new ticket or is no bug at all? If the ticket should remain closed, I would be happy to discuss the problem here.