I could use a bit of help in testing a patch...

[Richard Purdie]

kdf:
> Having tested this on my linux setup, I'm not getting good reponses.
There are
> a lot of the following:
>
> 2004-04-27 23:53:15.1609 No URL passed to InfoHash::info
(/mnt/mp3/Unsorted/The
> The - Test Fi
> le.mp3)
> 2004-04-27 23:53:15.1617 Backtrace:
>
> frame 0: Slim::Music::Info::infoHash (Slim/Music/Info.pm line 883)
> frame 1: Slim::Music::Info::infoFormat (Slim/Music/Info.pm line 2428)
> frame 2: Slim::Music::Info::readCoverArtFiles (Slim/Music/Info.pm line
2165)

I couldn't reproduce the error here but I can tell where the problems are
coming from by looking at the backtrace. It's another call from
readCoverArtFiles causing problems.

Changing $artwork = infoFormat($file, $1)."$suffix";
to
$artwork = infoFormat(Slim::Utils::Misc::fileURLFromPath($fil e),
$1)."$suffix";

on line 2424 should fix that.

> I've changed the debug msg from "None URL" to "No URL", but the rest
happens for
> just about every song under linux. I'm going to hold off committing this
and
> let Richard have time for an update if this is a known issue. I haven't
been
> keeping track on the fullness of the changes. I'll take a look at this
over the
> next few days and see what I can do, if there is nothing else.

The only errors I've seen are the ones you've reported so you have all the
changes I know of. It's a just case of fixing each case where things go
wrong now. I'm holding off further work until this makes it into CVS as the
changes are big enough without me altering the caching code as well.

Cheers,

RP.

[kdf]

Thanks Richard,

It might have been missed parts of the original patch. I have several copies of
the server all over the place. This latest is the one I use for server commits,
and I am still no expert at merging patches.

It seems to me that this patch could have odd effects for existing playlists,
referencing files instead of fileURL's. Do we have a plan for migrating these?

-kdf

Quoting Richard Purdie <rpurdie (AT) rpsys (DOT) net>:

> kdf:
> > Having tested this on my linux setup, I'm not getting good reponses.
> There are
> > a lot of the following:
> >
> > 2004-04-27 23:53:15.1609 No URL passed to InfoHash::info
> (/mnt/mp3/Unsorted/The
> > The - Test Fi
> > le.mp3)
> > 2004-04-27 23:53:15.1617 Backtrace:
> >
> > frame 0: Slim::Music::Info::infoHash (Slim/Music/Info.pm line 883)
> > frame 1: Slim::Music::Info::infoFormat (Slim/Music/Info.pm line 2428)
> > frame 2: Slim::Music::Info::readCoverArtFiles (Slim/Music/Info.pm line
> 2165)
>
> I couldn't reproduce the error here but I can tell where the problems are
> coming from by looking at the backtrace. It's another call from
> readCoverArtFiles causing problems.
>
> Changing $artwork = infoFormat($file, $1)."$suffix";
> to
> $artwork = infoFormat(Slim::Utils::Misc::fileURLFromPath($fil e),
> $1)."$suffix";
>
> on line 2424 should fix that.
>
> > I've changed the debug msg from "None URL" to "No URL", but the rest
> happens for
> > just about every song under linux. I'm going to hold off committing this
> and
> > let Richard have time for an update if this is a known issue. I haven't
> been
> > keeping track on the fullness of the changes. I'll take a look at this
> over the
> > next few days and see what I can do, if there is nothing else.
>
> The only errors I've seen are the ones you've reported so you have all the
> changes I know of. It's a just case of fixing each case where things go
> wrong now. I'm holding off further work until this makes it into CVS as the
> changes are big enough without me altering the caching code as well.
>
> Cheers,
>
> RP.
>
>

[kdf]

howdy,

I'm running into another problem. I cannot save a playlist. I click on save,
and I get the following from d_http, with the end result that there is no field
for naming and saving the playlist:

004-04-28 04:07:55.2415 Generating response for (htm, text/html) browse.html
2004-04-28 04:07:55.2443 browse virtual path: __playlists/__current.m3u
2004-04-28 04:07:55.2449 with absolute path:
file:///usr/local/slimserver/playlists/__current
..m3u
2004-04-28 04:07:55.2457 Saving playlist of 9868 items to
file:///usr/local/slimserver/playli
sts/__current.m3u
Use of uninitialized value in string ne at Slim/Web/Pages.pm line 229.
Use of uninitialized value in concatenation (.) or string at Slim/Web/Pages.pm
line 255.
2004-04-28 04:07:55.6581 lastpath equals
Use of uninitialized value in string eq at Slim/Web/Pages.pm line 257.
Use of uninitialized value in substitution (s///) at Slim/Web/Pages.pm line 262.


as soon as I can get through the errors, I'll commit the whole thing for the
rest to pound on. In the meantime, I have no alarm to wake me up for work,
becuase the playlist is invalid and I cannot save a new one
-kdf

[Richard Purdie]

kdf:
> It might have been missed parts of the original patch. I have several
copies of
> the server all over the place. This latest is the one I use for server
commits,
> and I am still no expert at merging patches.

I'll put together a complete patch with all the changes in it if that would
be easier.

> It seems to me that this patch could have odd effects for existing
playlists,
> referencing files instead of fileURL's. Do we have a plan for migrating
these?

It's already taken care of (I think). There's a line added to the playlist
parse functions which converts any none fileURL into a fileURL as it's read
in.

--
RP

[Richard Purdie]

> I'm running into another problem. I cannot save a playlist. I click on
save,
> and I get the following from d_http, with the end result that there is no
field
> for naming and saving the playlist:
>
> [snip very useful debug]
>
> as soon as I can get through the errors, I'll commit the whole thing for
the
> rest to pound on.

I've found the problem which caused the above. I misunderstood some code and
my alterations therefore didn't work.

I've attached a complete updated patch against CVS which fixes that and all
other known issues.

> In the meantime, I have no alarm to wake me up for work,
> becuase the playlist is invalid and I cannot save a new one

Sorry about that... :-/

--
RP

[kdf]

Quoting Richard Purdie <rpurdie (AT) rpsys (DOT) net>:

> > I'm running into another problem. I cannot save a playlist. I click on
> save,
> > and I get the following from d_http, with the end result that there is no
> field
> > for naming and saving the playlist:
> >
> > [snip very useful debug]
> >
> > as soon as I can get through the errors, I'll commit the whole thing for
> the
> > rest to pound on.
>
> I've found the problem which caused the above. I misunderstood some code and
> my alterations therefore didn't work.
>
> I've attached a complete updated patch against CVS which fixes that and all
> other known issues.
>
Thanks.

> > In the meantime, I have no alarm to wake me up for work,
> > becuase the playlist is invalid and I cannot save a new one
>
> Sorry about that... :-/

no problem. as luck would have it, I'm an insomniac
-kdf

[dean]

I've committed a couple of minor tweaks to Slim::Utils::Misc.pm that
fix some problems with file: paths on Windows.

Anybody else seen any other problems?

-dean

On Apr 28, 2004, at 5:14 AM, Richard Purdie wrote:

>> I'm running into another problem. I cannot save a playlist. I click
>> on
> save,
>> and I get the following from d_http, with the end result that there
>> is no
> field
>> for naming and saving the playlist:
>>
>> [snip very useful debug]
>>
>> as soon as I can get through the errors, I'll commit the whole thing
>> for
> the
>> rest to pound on.
>
> I've found the problem which caused the above. I misunderstood some
> code and
> my alterations therefore didn't work.
>
> I've attached a complete updated patch against CVS which fixes that
> and all
> other known issues.
>
>> In the meantime, I have no alarm to wake me up for work,
>> becuase the playlist is invalid and I cannot save a new one
>
> Sorry about that... :-/
>
> --
> RP
> <s42.diff>

[kdf]

Phil Barrett posted something earlier:
locahost:9000/stream.mp3 was being passed from iTunes and would fail at the -e
test Info.pm line 772. iTunes 4.5 and OSX I believe.

> 2004-04-28 20:07:54.4885 None URL passed to updateCacheEntry::info
> (localhost:9000/stream.mp3)
> 2004-04-28 20:07:54.4929 Backtrace:
>
> frame 0: Slim::Music::Info::updateCacheEntry
> (/Users/phil/slim/server/Slim/Music/iTunes.pm line 485)
> frame 1: Slim::Music::iTunes::scanFunction
> (/Users/phil/slim/server/Slim/Utils/Scheduler.pm line 95)
> frame 2: Slim::Utils::Scheduler::run_tasks (./server/slimserver.pl
> line 410)
> frame 3: main::idle (./server/slimserver.pl line 368)
> frame 4: main::main (./server/slimserver.pl line 820)

-kdf

Quoting dean blackketter <dean (AT) slimdevices (DOT) com>:

> I've committed a couple of minor tweaks to Slim::Utils::Misc.pm that
> fix some problems with file: paths on Windows.
>
> Anybody else seen any other problems?
>
> -dean
>
> On Apr 28, 2004, at 5:14 AM, Richard Purdie wrote:
>
> >> I'm running into another problem. I cannot save a playlist. I click
> >> on
> > save,
> >> and I get the following from d_http, with the end result that there
> >> is no
> > field
> >> for naming and saving the playlist:
> >>
> >> [snip very useful debug]
> >>
> >> as soon as I can get through the errors, I'll commit the whole thing
> >> for
> > the
> >> rest to pound on.
> >
> > I've found the problem which caused the above. I misunderstood some
> > code and
> > my alterations therefore didn't work.
> >
> > I've attached a complete updated patch against CVS which fixes that
> > and all
> > other known issues.
> >
> >> In the meantime, I have no alarm to wake me up for work,
> >> becuase the playlist is invalid and I cannot save a new one
> >
> > Sorry about that... :-/
> >
> > --
> > RP
> > <s42.diff>

[kdf]

seems the latest stuff made my music folder invalid. /mnt/mp3 no longer
registers, and I get the message that I need to set the audiodir.

I also had this, in reference to a saved playlist:


004-04-28 19:47:44.5690 None URL passed to updateCacheEntry::info
(./file:/usr/local/slimser
ver/playlists/__00_04_20_05_32_e2.m3u)
2004-04-28 19:47:44.5695 Backtrace:

frame 0: Slim::Music::Info::updateCacheEntry (Slim/Music/Info.pm line 2191)
frame 1: Slim::Music::Info::readTags (Slim/Music/Info.pm line 1202)
frame 2: Slim::Music::Info::info (Slim/Music/Info.pm line 1481)
frame 3: Slim::Music::Info::cachedPlaylist (Slim/Utils/Scan.pm line 392)
frame 4: Slim::Utils::Scan::readList (Slim/Utils/Scan.pm line 124)
frame 5: Slim::Utils::Scan::addToList (Slim/Control/Command.pm line 373)
frame 6: Slim::Control::Command::execute (Slim/Player/Client.pm line 900)
frame 7: Slim::Player::Client::startup (Slim/Player/Player.pm line 39)
frame 8: Slim::Player::Player::init (Slim/Networking/Slimproto.pm line 293)
frame 9: Slim::Networking::Slimproto:rocess_slimproto_frame
(Slim/Networking/Slimproto.p
m line 234)
frame 10: Slim::Networking::Slimproto::client_readable
(Slim/Networking/Select.pm line 78)
frame 11: Slim::Networking::Select::select (./slimserver.pl line 425)
frame 12: main::idle (./slimserver.pl line 367)
frame 13: main::main (./slimserver.pl line 812)

Use of uninitialized value in open at Slim/Utils/Scan.pm line 430.

Quoting dean blackketter <dean (AT) slimdevices (DOT) com>:

> I've committed a couple of minor tweaks to Slim::Utils::Misc.pm that
> fix some problems with file: paths on Windows.
>
> Anybody else seen any other problems?
>
> -dean
>
> On Apr 28, 2004, at 5:14 AM, Richard Purdie wrote:
>
> >> I'm running into another problem. I cannot save a playlist. I click
> >> on
> > save,
> >> and I get the following from d_http, with the end result that there
> >> is no
> > field
> >> for naming and saving the playlist:
> >>
> >> [snip very useful debug]
> >>
> >> as soon as I can get through the errors, I'll commit the whole thing
> >> for
> > the
> >> rest to pound on.
> >
> > I've found the problem which caused the above. I misunderstood some
> > code and
> > my alterations therefore didn't work.
> >
> > I've attached a complete updated patch against CVS which fixes that
> > and all
> > other known issues.
> >
> >> In the meantime, I have no alarm to wake me up for work,
> >> becuase the playlist is invalid and I cannot save a new one
> >
> > Sorry about that... :-/
> >
> > --
> > RP
> > <s42.diff>

[kdf]

it appears that the new version of Misc.pm changes /mnt/mp3 to ./file:/mnt/mp3,
which registers as invalid. Thus, the scan is now dead in Linux. at least for me.

-kdf

Quoting dean blackketter <dean (AT) slimdevices (DOT) com>:

> I've committed a couple of minor tweaks to Slim::Utils::Misc.pm that
> fix some problems with file: paths on Windows.
>
> Anybody else seen any other problems?
>
> -dean
>
> On Apr 28, 2004, at 5:14 AM, Richard Purdie wrote:
>
> >> I'm running into another problem. I cannot save a playlist. I click
> >> on
> > save,
> >> and I get the following from d_http, with the end result that there
> >> is no
> > field
> >> for naming and saving the playlist:
> >>
> >> [snip very useful debug]
> >>
> >> as soon as I can get through the errors, I'll commit the whole thing
> >> for
> > the
> >> rest to pound on.
> >
> > I've found the problem which caused the above. I misunderstood some
> > code and
> > my alterations therefore didn't work.
> >
> > I've attached a complete updated patch against CVS which fixes that
> > and all
> > other known issues.
> >
> >> In the meantime, I have no alarm to wake me up for work,
> >> becuase the playlist is invalid and I cannot save a new one
> >
> > Sorry about that... :-/
> >
> > --
> > RP
> > <s42.diff>