Busy day, let's wrap it up

[dean]

Hey Folks,

Nice work to Dan and KDF for their excellent cleaning and fixing work,
along with the new cover art feature.

I'd like to wrap up development on 5.0.3 this week and get out a really
solid new official release.

So, to this end, please post any patches for review before they go in
and let's keep it to bug fixes until we release.

Thanks to all,

dean

p.s. I'm behind in some submitted patches from other folks. Stay
tuned on these...

[Richard Purdie]

> I'd like to wrap up development on 5.0.3 this week and get out a really
> solid new official release.

Sounds good.

> p.s. I'm behind in some submitted patches from other folks. Stay
> tuned on these...

Attached is a further enhancement of my patch for bug 131. It should be
applied after my previous patch (s4.diff).

It converts types like aiff into aif (I found the function).

It also returns error 400 if we a) don't recognise the type or b) can't find
a command to convert to it.

s9.diff adds an if statement to Source.pm so any files which aren't mp3
files and which aren't going to a squeezebox get full headers.

There is one remaining problem which is silence.mp3. This gets streamed
regardless of the type of stream and is going to be a pain. It should
probably get piped though getcommand although I don't see an easy way to do
it...

I've tested quite throughly and wav streaming does work (if you connect to
the stream after starting it playing to avoid silence.mp3). I get 400 errors
when I should as well. We just need some players that support these types of
stream now (quicktime in my browser appeared to although I didn't try track
changeover which will be the tricky bit with these streams).

RP

[dean]

Richard,

Could you post a single comprehensive patch. I'm afraid I'm going to
miss something...


On Jan 13, 2004, at 5:38 AM, Richard Purdie wrote:

>> I'd like to wrap up development on 5.0.3 this week and get out a
>> really
>> solid new official release.
>
> Sounds good.
>
>> p.s. I'm behind in some submitted patches from other folks. Stay
>> tuned on these...
>
> Attached is a further enhancement of my patch for bug 131. It should be
> applied after my previous patch (s4.diff).
>
> It converts types like aiff into aif (I found the function).
>
> It also returns error 400 if we a) don't recognise the type or b)
> can't find
> a command to convert to it.
>
> s9.diff adds an if statement to Source.pm so any files which aren't mp3
> files and which aren't going to a squeezebox get full headers.
>
> There is one remaining problem which is silence.mp3. This gets streamed
> regardless of the type of stream and is going to be a pain. It should
> probably get piped though getcommand although I don't see an easy way
> to do
> it...
>
> I've tested quite throughly and wav streaming does work (if you
> connect to
> the stream after starting it playing to avoid silence.mp3). I get 400
> errors
> when I should as well. We just need some players that support these
> types of
> stream now (quicktime in my browser appeared to although I didn't try
> track
> changeover which will be the tricky bit with these streams).
>
> RP
> <s8.diff><s9.diff>

[Richard Purdie]

> Could you post a single comprehensive patch. I'm afraid I'm going to
> miss something...

Ok. Which ones do you want?

I'm guessing you want:

All patches for Bug 131
Patch to add dirtycache flag
Patch to remove cached entries about uncached images upon rescan.

and not:

The patch which adds the wipecache functionality. (although I may as well
include the code which adds the function to Info.pm and adds it to the
Command Line interface, just not the UI change).

I submitted them indiviudally as I didn't know if you'd want to apply them
all. I'm having fun with CVS now as my files are getting very out of sync
. The original patches no longer apply cleanly...

RP

[dean]

I'd like all of them to look at. As long as they don't break anything,
I'm not opposed to adding any of them, including the wipecache button.


On Jan 13, 2004, at 9:05 AM, Richard Purdie wrote:

>> Could you post a single comprehensive patch. I'm afraid I'm going to
>> miss something...
>
> Ok. Which ones do you want?
>
> I'm guessing you want:
>
> All patches for Bug 131
> Patch to add dirtycache flag
> Patch to remove cached entries about uncached images upon rescan.
>
> and not:
>
> The patch which adds the wipecache functionality. (although I may as
> well
> include the code which adds the function to Info.pm and adds it to the
> Command Line interface, just not the UI change).
>
> I submitted them indiviudally as I didn't know if you'd want to apply
> them
> all. I'm having fun with CVS now as my files are getting very out of
> sync
> . The original patches no longer apply cleanly...
>
> RP
>
>
>
>

[Richard Purdie]

> I'd like all of them to look at. As long as they don't break anything,
> I'm not opposed to adding any of them, including the wipecache button.

A complete patch is attached. None of it should break anything.

RP

[Richard Purdie]

> > I'd like all of them to look at. As long as they don't break anything,
> > I'm not opposed to adding any of them, including the wipecache button.
>
> A complete patch is attached. None of it should break anything.

Nearly complete :-/. I missed out the strings.txt additions it needs. Patch
attached.

Sorry,

RP