Proposed patch to default skin

[Neil Sleightholm]

I would like to propose the following 2 patches for the default skin.

This adds a small space to the right of the playlist control so they aren't tight against the playing box.

Index: slimserver.css
===================================================================
--- slimserver.css	(revision 5858)
+++ slimserver.css	(working copy)
@@ -365,6 +365,7 @@
 	position: absolute;
 	top: 0px;
 	padding-top: 6px;
+	padding-right: 6px;
 	right: 10px;
 }

This adds a small space after the "POWER:", "VOLUME:", "REPEAT:" and "SHUFFLE:" text because I think it looks nicer!

Index: status_header.html
===================================================================
--- status_header.html	(revision 5858)
+++ status_header.html	(working copy)
@@ -44,7 +44,7 @@
 
 		[% IF isplayer %]
 		<div id="powerButtons">
-			<div class="attributeBold">[% "POWER" | string | upper %]:</div>
+			<div class="attributeBold">[% "POWER" | string | upper %]:&nbsp;</div>
 
 			[% PROCESS statusLink p0 = 'power' p1 = 1 linkString = 'ON'  divID = mode == 'on'  ? 'valueSelected' : 'valueBold' %]
 			<span class="bar">|</span>
@@ -66,11 +66,11 @@
 		[% IF isplayer %]
 		<div id="volumeButtons">
 
-			<div class="attributeBold">[% "VOLUME" | string | upper %]:</div>
+			<div class="attributeBold">[% "VOLUME" | string | upper %]:&nbsp;</div>
 
 			[%- FOREACH vol = [0,10,20,30,40,50,60,70,80,90,100] %]
 
@@ -87,7 +87,7 @@
 	<div id="topGraphicMenu2">
 		<div id="repeatButtons">
 
-			<div class="attributeBold">[% "REPEAT" | string | upper %]:</div>
+			<div class="attributeBold">[% "REPEAT" | string | upper %]:&nbsp;</div>
 
 			[% repeatStrings = ['OFF', 'ONE', 'ALL'] %]
 
@@ -110,7 +110,7 @@
 
 		<div id="shuffleButtons">
 
-			<div class="attributeBold">[% "SHUFFLE" | string | upper %]:</div>
+			<div class="attributeBold">[% "SHUFFLE" | string | upper %]:&nbsp;</div>
 
 			[% shuffleStrings = ['OFF', 'SONGS', 'ALBUMS'] %]

Neil

[kdf]

Neil Sleightholm wrote:
> I would like to propose the following 2 patches for the default skin.
>
I'm not sure this works. The status_header change looks ok, but the css
change seems to be causing the playlist controls to appear on the left
side mingled with the text in Firefox. In IE, the controls push right up
next to the text and are not aligned with the right edge.

As a side note, patches are easier to deal with if they are attache, as
a diff if that is allowed in the forum or a gzipped diff. Cutting and
pasting from the raw text is a bit prone to error.

-kdf

[gregklanderman]

>>>>> Kevin Deane-Freeman <slim-mail (AT) deane-freeman (DOT) com> writes:

> patches are easier to deal with if they are attache, as a diff
> if that is allowed in the forum or a gzipped diff.

I'm not sure I parsed that correctly.. if I'm using the mail
interface, can I attach diffs, or do they need to be gzipped?

greg

[kdf]

Greg Klanderman wrote:

> I'm not sure I parsed that correctly.. if I'm using the mail
> interface, can I attach diffs, or do they need to be gzipped?
>

I think gzip is probably the safest method. i'm not sure if diffs would
stay as attachments ot not when they pass through the gateway.
-k

[Neil Sleightholm]

I'm not sure this works. The status_header change looks ok, but the css
change seems to be causing the playlist controls to appear on the left
side mingled with the text in Firefox. In IE, the controls push right up
next to the text and are not aligned with the right edge.

As a side note, patches are easier to deal with if they are attache, as
a diff if that is allowed in the forum or a gzipped diff. Cutting and
pasting from the raw text is a bit prone to error.

-kdf

I don't see either problem so I think it is probably the diff file. I'll try and generate it again and see if that is any better.

Neil

[Neil Sleightholm]

I don't think my diff generation is correct (I'm using TortoiseSVN on Windows). The actual change is to ".playlistControls" and adds the single line "padding-right: 6px;" e.g.:

.playlistControls {
	position: absolute;
	top: 0px;
	padding-top: 6px;
	padding-right: 6px;
	right: 10px;
}

Is this how the patch was applied?

Neil

[kdf]

Quoting Neil Sleightholm
<Neil.Sleightholm.22b1hn (AT) no-mx (DOT) forums.slimdevices.com>:

>
> I don't think my diff generation is correct (I'm using TortoiseSVN on
> Windows). The actual change is to ".playlistControls" and adds the
> single line "padding-right: 6px;" e.g.:
>
>
> Code:
> --------------------
> .playlistControls {
> position: absolute;
> top: 0px;
> padding-top: 6px;
> padding-right: 6px;
> right: 10px;
> }
> --------------------
> Is this how the patch was applied?

That's correct. The line numbers matched up, so that's where I placed
the change. Pasting that in and refreshing caused the problems I
mentioned, cutting it out and refreshing went right back to where it is
in the current builds.
-k

[Neil Sleightholm]

That's odd, I'll investigate some more.

[Neil Sleightholm]

Could you let me know which OS and browse versions you where using so I can investigate some more. Thanks.

Neil

[kdf]

Neil Sleightholm wrote:
> Could you let me know which OS and browse versions you where using so I
> can investigate some more. Thanks.
>
Windows XP SP2, using a fully updated IE 6 and Firefox 1.5. There were
slight differences in how they behaved (as always), but my initial
reponse noted the firefox/ie differences. I also tried with Win2k at
work, with similar results. I'm willing to try again with a diff that I
can use with patch, just in case I was just too much of a clod with the
manual patching.

It may also be getting mised in with all the stuff I've been doing
lately outside of trunk, though it should only really be affecting the
settings pages. Might be simply a matter of waiting until I can clean
up what I have. There is a lot to managed locally at the mo.

-k