Suppress screensaver if brightness ==0

[Triode]

Hi,

Max Spicer suggested that a screensaver should not run if brightness is set to 0 in power off mode - to minimse network bandwidth
and server activity when in this state. [bug 1745] (See discuss list for more details of Max's requirements, specific to Rss) I
think the attached achieves Max's requirements.

I would like feedback from people with more experience of the server history as I've made one change to the old code: 'off' mode now
returns a blank screen rather than dateTime in its lines function.

This avoids the brief clock display before switching into a screensaver and relies on dateTime screensaver for the clock display.
Was there any other reason for off mode to return dateTime or is this just historical??

Adrian

[max.spicer]

Was there ever a solution to the fact that posts coming via the newsgroups/mailing lists don't keep there attachments when received on the forums? No sign of any attachment from my vBulletin point of view. :-(

Max

Hi,

Max Spicer suggested that a screensaver should not run if brightness is set to 0 in power off mode - to minimse network bandwidth
and server activity when in this state. [bug 1745] (See discuss list for more details of Max's requirements, specific to Rss) I
think the attached achieves Max's requirements.

I would like feedback from people with more experience of the server history as I've made one change to the old code: 'off' mode now
returns a blank screen rather than dateTime in its lines function.

This avoids the brief clock display before switching into a screensaver and relies on dateTime screensaver for the clock display.
Was there any other reason for off mode to return dateTime or is this just historical??

Adrian

[Triode]

Let me try again with a vBulletin attachement (assuming I can make it work...)

[Triode]

> I would like feedback from people with more experience of the server history as I've made one change to the old code: 'off' mode
> now
> returns a blank screen rather than dateTime in its lines function.
>

Updated version which does the same thing for brightness == 0 in on mode. This changes the lines function to one which returns a
blank screen when brightness is 0.

I've introduced a new mode 'blank' with its own map in Default.map for this so that buttons can be passed back when pressed after
the brightness is changed.
Did I do this in the right way and have I trapped all the right buttons? [first time I've looked at this bit of code]

Adrian

[dean]

I'm confused by this. Isn't the bug that the screensaver shouldn't
kick in if the brightness is zero? Seems like a much simpler change
(and less risky as we get closer to 6.1...)


On Jul 3, 2005, at 5:12 PM, Triode wrote:

>> I would like feedback from people with more experience of the
>> server history as I've made one change to the old code: 'off' mode
>> now
>> returns a blank screen rather than dateTime in its lines function.
>>
>>
>
> Updated version which does the same thing for brightness == 0 in on
> mode. This changes the lines function to one which returns a blank
> screen when brightness is 0.
>
> I've introduced a new mode 'blank' with its own map in Default.map
> for this so that buttons can be passed back when pressed after the
> brightness is changed.
> Did I do this in the right way and have I trapped all the right
> buttons? [first time I've looked at this bit of code]
>
> Adrian
>
> <saver2.diff>
>

[Triode]

Dean,

Max also wants to start and stop the screen saver just by changing brightness. So he can select Rss and then actually stop it being
involked and sending stuff to the player by setting brightness to 0. However when he wants to read it he then just wants to change
the brightness. The first patch does this for off mode only. I think this latter patch is more general in that it suppresses
updates and animiation if brightness is set to 0 by pushing into a new mode.

I was actually thinking this would miss 6.1, but perhaps the first patch I posted which is much simpler and only does this for 'off'
mode could be considered?

Adrian

> I'm confused by this. Isn't the bug that the screensaver shouldn't kick in if the brightness is zero? Seems like a much simpler
> change (and less risky as we get closer to 6.1...)
>

[max.spicer]

Missing from vBulletin again. Could you attach the patches to the bug instead? I'd have thought that would be a more sensible holding place for them anyway.

Max

>
Updated version which does the same thing for brightness == 0 in on mode. This changes the lines function to one which returns a
blank screen when brightness is 0.

I've introduced a new mode 'blank' with its own map in Default.map for this so that buttons can be passed back when pressed after
the brightness is changed.
Did I do this in the right way and have I trapped all the right buttons? [first time I've looked at this bit of code]

Adrian

[dean]

I'm not sure we want to overload the brightness button to also mean
"pause the screensaver".

The brightness button shouldn't affect the screensaver. Indeed, a
new brightness setting has recently been added so that you can adjust
the
screensaver brightness while the screensaver is ticking. This makes
three independent brightness settings (powered on, powered off,
screensaver).

Optimizing CPU and network performance to not calculate or send
screen updates when the display is dimmed is a noble goal, but the
end-user behavior probably shouldn't change.


On Jul 4, 2005, at 3:15 AM, Triode wrote:

> Dean,
>
> Max also wants to start and stop the screen saver just by changing
> brightness. So he can select Rss and then actually stop it being
> involked and sending stuff to the player by setting brightness to
> 0. However when he wants to read it he then just wants to change
> the brightness. The first patch does this for off mode only. I
> think this latter patch is more general in that it suppresses
> updates and animiation if brightness is set to 0 by pushing into a
> new mode.
>
> I was actually thinking this would miss 6.1, but perhaps the first
> patch I posted which is much simpler and only does this for 'off'
> mode could be considered?
>
> Adrian
>
>
>> I'm confused by this. Isn't the bug that the screensaver
>> shouldn't kick in if the brightness is zero? Seems like a much
>> simpler change (and less risky as we get closer to 6.1...)
>>
>>
>
>

[Triode]

Ok lets leave for until after 6.1.

I would like feedback from Max anyway - any comments Max?

I must admit to being reasonably happy with the power off one as wouldn't expect users to notice any difference. It is likely they
are using date time or Rss screensavers - for date time you can notice no difference. For Rss, it does go back to the start, but if
users are diming the display to zero for a reason they are unlikely to notice this.

Adrian

> I'm not sure we want to overload the brightness button to also mean "pause the screensaver".
>
> The brightness button shouldn't affect the screensaver. Indeed, a new brightness setting has recently been added so that you can
> adjust the
> screensaver brightness while the screensaver is ticking. This makes three independent brightness settings (powered on, powered
> off, screensaver).
>
> Optimizing CPU and network performance to not calculate or send screen updates when the display is dimmed is a noble goal, but
> the end-user behavior probably shouldn't change.

[sbjaerum]

Ok lets leave for until after 6.1.

I would like feedback from Max anyway - any comments Max?

I must admit to being reasonably happy with the power off one as wouldn't expect users to notice any difference. It is likely they
are using date time or Rss screensavers - for date time you can notice no difference. For Rss, it does go back to the start, but if
users are diming the display to zero for a reason they are unlikely to notice this.

Adrian

> I'm not sure we want to overload the brightness button to also mean "pause the screensaver".
>
> The brightness button shouldn't affect the screensaver. Indeed, a new brightness setting has recently been added so that you can
> adjust the
> screensaver brightness while the screensaver is ticking. This makes three independent brightness settings (powered on, powered
> off, screensaver).
>
> Optimizing CPU and network performance to not calculate or send screen updates when the display is dimmed is a noble goal, but
> the end-user behavior probably shouldn't change.

I agree with Adrian. I can't see that the end-user behavior is changed, just a reduction in CPU and network bandwidth.

Steinar