Home of the Squeezebox™ & Transporter® network music players.
Results 1 to 6 of 6

Thread: FileViewer

  1. #1
    jvromans@squirrel.nl
    Guest

    FileViewer

    Hi,

    Some time ago I modified Michael's FileViewer plugin to understand some
    simple directives in the contents of the file to be displayed:

    [center] center the lines
    [date] display the date
    [time] display the time

    I use the plugin to obtain a permanent display of the performance of my
    solar panels, by periodically write a file with contents:

    [center][date]
    [time] - 3.1 kW (29.2 kWh)

    The changes I made are backward compatible with Michael's original
    FileViewer. I attach them as a patch against version 1.5. It would be nice
    if they could be added to the standard plugin.

    Thanks & regards,

    Johan



  2. #2
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,746

    FileViewer

    Hey Johan,

    > The changes I made are backward compatible with Michael's original
    > FileViewer. I attach them as a patch against version 1.5. It would be nice
    > if they could be added to the standard plugin.


    hehe... 6 years after the last update? :-)

    It looks as if your changed file was based on 1.5.1, but you diffed
    against 1.5.0 or something. Could you please send me a copy of the
    edited file, or make sure you diff against 1.5.1? The patch wouldn't
    merge, there are conflicts. Eg. 1.5.1 didn't have the version string in
    the code. But your patch still has 1.5 in there.

    --

    Michael

  3. #3
    jvromans@squirrel.nl
    Guest

    FileViewer

    On Tue, 15 Aug 2017 07:48:14 +0200, Michael Herger <slim (AT) herger (DOT) net> wrote:

    > It looks as if your changed file was based on 1.5.1, but you diffed
    > against 1.5.0 or something.


    Looking for a reference source, I downloaded the zip from
    http://www.herger.net/slim-plugins/d...e=slim-plugins
    assuming this was the last version...

    > Could you please send me a copy of the
    > edited file, or make sure you diff against 1.5.1? The patch wouldn't
    > merge, there are conflicts. Eg. 1.5.1 didn't have the version string in
    > the code. But your patch still has 1.5 in there.


    Attached, thanks!

    -- Johan


  4. #4
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,746

    FileViewer

    > Looking for a reference source, I downloaded the zip from
    > http://www.herger.net/slim-plugins/d...e=slim-plugins
    > assuming this was the last version...


    Oh my... this pre-dates the plugin installer! I need to purge some of my
    pages.

    --

    Michael

  5. #5
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,746

    FileViewer

    Thanks Johan. While I like the idea of having a limited set of
    formatting options, I don't like the fact that this is fundamentally
    changing how the plugin treated file input before. It makes assumptions
    about the file's content which might not be true for most users. The
    code would now take the first line as the title, then concatenate the
    rest to be shown as the second line. Previously the first line was
    reserved for the plugin's title (whether that was a good choice or not
    could be subject of another discussion :-)).

    I don't know how many users of this plugin still are out there. But
    those who are probably don't want the behaviour changed after all these
    years.

    --

    Michael

  6. #6
    jvromans@squirrel.nl
    Guest

    FileViewer

    Hi Michael,

    I didn't intend to make changes that would affect current behaviour too
    much, but your point is valid. I'll keep this version for my private
    purposes.

    Thanks,
    Johan

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •