Home of the Squeezebox™ & Transporter® network music players.
Page 2 of 2 FirstFirst 12
Results 11 to 13 of 13
  1. #11
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,779

    call a Perl function in an html page

    > I've proposed a patch, although this touches a very sensitive piece of
    > LMS, so you probably do not want to mofigy that lightly and I'm not
    > really good at Perl, so my code probably contains some "naive" errors.

    Yeah, indeed.... I found a limitation in that code, too, when working on
    Spotty. I decided to sub-class SimpleAsyncHTTP rather than "fix" it in
    LMS, as I don't want to break other stuff. How did you solve the issue
    for your plugin?

    Thanks anyway. I'll definitely look into this. Or keep it in the back of
    my head in case that issue comes up again.

    --
    --

    Michael

  2. #12
    Senior Member
    Join Date
    May 2008
    Location
    Canada
    Posts
    3,284

    call a Perl function in an html page

    Quote Originally Posted by mherger View Post
    > I've proposed a patch, although this touches a very sensitive piece of
    > LMS, so you probably do not want to mofigy that lightly and I'm not
    > really good at Perl, so my code probably contains some "naive" errors.

    Yeah, indeed.... I found a limitation in that code, too, when working on
    Spotty. I decided to sub-class SimpleAsyncHTTP rather than "fix" it in
    LMS, as I don't want to break other stuff. How did you solve the issue
    for your plugin?

    Thanks anyway. I'll definitely look into this. Or keep it in the back of
    my head in case that issue comes up again.

    --
    --

    Michael
    I could not subclass it easily because the functions I wanted to replace were not use as methods (although I still need to figure out a few things in Perl wrt this topic). At the beginning I did a minimal version then after that I decided to take the complete async::http and made it local part of my plugin then modify the minimum so that it can be part of your code if you want it one day.


    EnvoyÚ de mon iPad en utilisant Tapatalk
    LMS 7.7, 7.8 and 7.9 - 5xRadio, 3xBoom, 4xDuet, 1xTouch, 1 SB2. Sonos PLAY:3, PLAY:5, Marantz NR1603, JBL OnBeat, XBoxOne, XBMC, Foobar2000, ShairPortW, JRiver 21, 2xChromecast Audio, Chromecast v1 and v2, , Pi B3, B2, Pi B+, 2xPi A+, Odroid-C1, Odroid-C2, Cubie2, Yamaha WX-010, AppleTV 4, Airport Express, GGMM E5

  3. #13
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,779

    call a Perl function in an html page

    > I could not subclass it easily because the function I wanted to replace
    > were not use as methods


    I hear you... Even though SimpleAsyncHTTP is mostly OO, I had to copy
    whole chunks of code, as the required parts actually were not
    implemented in an OO way...

    But it's a delicate part I wouldn't want to break in a stable build.

    --

    Michael

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •