Home of the Squeezebox™ & Transporter® network music players.
Page 1 of 6 123 ... LastLast
Results 1 to 10 of 58
  1. #1
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,761

    LMS 7.8.1 or 7.9.0? Which way to go?

    Hey,

    as I've been working on some changes in 7.8.1 I was more and more
    wondering whether I should have applied these to a new 7.9 branch
    instead of 7.8.1. The changes so far didn't touch much user-facing, but
    there's quite some movement in the code base, which can potentially lead
    to disruptive changes. I've been considering reverting those changes to
    get back to a rather stable 7.8.1 branch, then going forward with a new
    7.9 branch. While I've been stuck on a plain several people have brought
    up the same idea in various places (pm, forum). So what do you think
    about this plan:

    - 7.8 branch: revert the big changes to get back on a rather stable track

    - create 7.9 branch to implement the big changes which could be
    disruptive at times.

    Pros (from my pov):
    - more freedom to work on potentially breaking code changes
    - 7.8.x stays stable as it is
    - this is basically following and extending the previous pattern, where
    7.7 is stable & official, 7.8 stable but not official, 7.9 unstable

    Cons:
    - even more branches to keep in-sync with upstream fixes
    - even more confusion for users who want to have "the best" build
    - we're getting closer to the dreaded 8.0 release which was supposed to
    fix "everything for everyone" a long time ago :-)

    Opinions?

    --

    Michael

  2. #2
    Senior Member pippin's Avatar
    Join Date
    Oct 2007
    Location
    Berlin
    Posts
    14,142
    Given the level of change I'd vote for 7.9. Leave 7.8.1 for bug fixes and necessary changes that need to be implemented to keep up with eventual 7.7.4 changes
    ---
    learn more about iPeng, the iPhone and iPad remote for the Squeezebox and
    Logitech UE Smart Radio as well as iPeng Party, the free Party-App,
    at penguinlovesmusic.com
    New: iPeng 9, the Universal App for iPhone, iPad and Apple Watch

  3. #3
    Senior Member
    Join Date
    Feb 2008
    Posts
    4,164
    I like your 3 level solution:

    7.7 is stable & official, 7.8 stable but not official, 7.9 unstable
    Touch, Logitech Radio, Logitech UE Radio, O2 Joggler + SqpOS
    UPnPBridge - 2 paired Sonos Play1 speakers; Rocki - Sony SRS-BTM8 speaker; Pioneer WX-SMA1 speaker; - PURE One Flow internet radio: PURE Jongo S3x ; Jongo T2; Libratone Zipp
    Castbridge - Chromecast 1 + Chromecast Audio
    AirplayBridge - Loewe Airspeaker
    SB Player - Fire TV
    ------------------------------------------------------------------------------------

  4. #4
    Senior Member DJanGo's Avatar
    Join Date
    Sep 2005
    Location
    Germany
    Posts
    2,325
    Quote Originally Posted by castalla View Post
    I like your 3 level solution:

    7.7 is stable & official, 7.8 stable but not official, 7.9 unstable
    but not official

    why then LMS anyway?
    why not back2ther00ts like slimserver 8 or squeezeboxserver 8?

  5. #5
    Senior Member
    Join Date
    Apr 2005
    Location
    Hampshire, UK
    Posts
    197
    I agree with Pippin.

  6. #6
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,761

    LMS 7.8.1 or 7.9.0? Which way to go?

    > why then LMS anyway?

    Because such changes for the sake of change are a huge amount of work.

    > why not back2ther00ts like slimserver 8 or squeezeboxserver 8?


    Are you saying you volunteer to implement all changes required? Name
    change in all resource files for all languages (which is more than just
    search/replace!) and all platforms, update file paths, package names,
    and add migration code? Cool!

    If not, we'll stick with LMS a little longer.

    --

    Michael

  7. #7
    Senior Member erland's Avatar
    Join Date
    Dec 2005
    Location
    Sweden
    Posts
    11,010
    Quote Originally Posted by pippin View Post
    Given the level of change I'd vote for 7.9. Leave 7.8.1 for bug fixes and necessary changes that need to be implemented to keep up with eventual 7.7.4 changes
    +1
    Erland Isaksson (My homepage)
    Lead platform developer of ickStream Music Platform - A world of music at your fingertips

    (Also developer of many plugins/applets)

  8. #8
    jvromans@squirrel.nl
    Guest

    LMS 7.8.1 or 7.9.0? Which way to go?

    pippin <pippin.6c68qn (AT) no-mx (DOT) forums.slimdevices.com> writes:

    > Given the level of change I'd vote for 7.9. Leave 7.8.1 for bug fixes
    > and necessary changes that need to be implemented to keep up with
    > eventual 7.7.4 changes


    +1

  9. #9
    Senior Member JackOfAll's Avatar
    Join Date
    Dec 2005
    Location
    London, UK
    Posts
    2,749
    My tuppence, FWIW, although I suspect I will be alone on this...... The major version should be bumped. This is not so much because there are any major code changes that demand it is, more a case of what it signifies.

    Just so everyone is on the same page, 7.8.0, where x.x.x is major.minor.revision.

    7.8.0 -> 7.8.1, well it never was. It wasn't a minor bug fix.

    There is an argument for bumping the minor, 7.8 -> 7.9, and I see that, but I think that a clear line needs to be drawn in the sand, and bumping the major makes it clear that is what is happening.

    Anyway, whatever..... All I want to see is the public/7.8 branch stable. As stable as it has been for the past year. Too many people are pulling and "shipping" based on that 7.8 branch, having gotten used to it being stable, to mess with it.

  10. #10
    Babelfish's Best Boy mherger's Avatar
    Join Date
    Apr 2005
    Location
    Switzerland
    Posts
    19,761

    LMS 7.8.1 or 7.9.0? Which way to go?

    > My tuppence, FWIW, although I suspect I will be alone on this...... The
    > major version should be bumped.


    I'd rather think we should have a "trunk" or "master" again, with no
    final version number pre-defined. Major version numbers should come with
    major feature changes. To have an "anonymous" branch would allow to
    decide at release time whether it was worth the new number or not.
    Unless there was some real product planning with well defined targets etc.

    > This is not so much because there are
    > any major code changes that demand it is, more a case of what it
    > signifies.


    Which is?...

    > There is an argument for bumping the minor, 7.8 -> 7.9, and I see that,
    > but I think that a clear line needs to be drawn in the sand, and bumping
    > the major makes it clear that is what is happening.


    What would that clear line mean?

    > Anyway, whatever..... All I want to see is the public/7.8 branch stable.
    > As stable as it has been for the past year. Too many people are pulling
    > and "shipping" based on that 7.8 branch, having gotten used to it being
    > stable, to mess with it.


    Ok, we're all on the same page here. Cool. Except that now I guess I'll
    have to do it :-).

    A little word of a warning: developers who have branched from 7.8 might
    probably not like the change, as it's going to modify the git history.
    This might potentially cause problems merging with whatever you did in
    your clone. Most likely it won't cause any problem at all, though,
    unless you've further modified some of the (now still) 7.8.1 changes.
    You might need to rebase your work on top of 7.9.

    --

    Michael

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •