PDA

View Full Version : MusicIP, slimserver, accented characters problem, 1 solution, another problem



Pierre
2006-09-28, 14:18
I have installed MusicIP MIxer 1.7 and Slimserver 6.5 on my Windows XP platform.

I got some errors importing tracks having accented characters in the filename or in the path.

First I left the music folder field blank in the server settings. Slimserver would not import albums having accented characters in the path. For songs having accented characters in the filename, they would import OK, tags were OK, but when viewing song info in the server, the track filename would get garbled characters. After viewing the info, slimserver would remove the file from the DB as it was not able to find the file.

When setting the music folder field in slimserver, files would get duplicated.

I found a fix that fixes those problems. I modified the following line in MusicMagic Importer.pm:

for my $key (qw(album artist genre name)) {

to:

for my $key (qw(album artist genre name file)) {

Now, everything imports OK, display OK, and plays OK.

I found another problem:

If I browse a song with accented characters in filename and hold the play button (to launch a MusicMagic Mix), the song title appearing in the mix gets garbled. Also, a duplicate song is created in the database. When browsing with the server, I have one entry displaying the correct title pointing to the correct filename, and one entry with a garbled title pointing to a garbled filename. Here is an example.

6. Y Tú Qué Has Hecho de Buena Vista Social Club par Buena Vista Social Club
6. ¿Y Tú Qué Has Hecho? de Buena Vista Social Club par Buena Vista Social Club

Ideas anyone?

mherger
2006-09-28, 14:30
> I got some errors importing tracks having accented characters in the
> filename or in the path.
[..]
> I found a fix that fixes those problems. I modified the following line
> in MusicMagic Importer.pm:

This fix has been added yesterday
(http://bugs.slimdevices.com/show_bug.cgi?id=3318). Please update to the
latest (or tomorrow's) nightly build.

> I found another problem:

I think it's the same issue. Please give 6.5.1 a try.

--

Michael

-----------------------------------------------------------------
http://www.herger.net/SlimCD - your SlimServer on a CD
http://www.herger.net/slim - AlbumReview, Biography, MusicInfoSCR

Pierre
2006-09-28, 15:20
Thanks for the quick answer!

I tried 6.5.1. It fixed the import problem. However, the problem when generating a MusicIP Mix is still there.

Pierre
2006-09-28, 19:16
Added two lines in Plugin.pm in the following for loops:

for (my $j = 0; $j < $count; $j++) {

my $newPath = Plugins::MusicMagic::Common::convertPath($songs[$j]);

$::d_musicmagic && msg("MusicMagic: Original $songs[$j] : New $newPath\n");

push @mix, Slim::Utils::Misc::fileURLFromPath($newPath);
}

to make:

for (my $j = 0; $j < $count; $j++) {

my $enc = Slim::Utils::Unicode::encodingFromString($songs[$j]);
$songs[$j] = Slim::Utils::Unicode::utf8decode_guess($songs[$j], $enc);

my $newPath = Plugins::MusicMagic::Common::convertPath($songs[$j]);

$::d_musicmagic && msg("MusicMagic: Original $songs[$j] : New $newPath\n");

push @mix, Slim::Utils::Misc::fileURLFromPath($newPath);
}

It solves the MusicIP mix problem. Additional testing required to make sure it does not break anything else.

Pierre
2006-10-03, 10:50
The fix is working. Bug and solution reported as Bug #4281.

jeffluckett
2006-10-03, 11:03
Greetings,

I downloaded the nightly from last night (SlimServer Version: 6.5.1 - 10130 - Windows Server 2003 - EN - cp1252) installed and rescanned hoping to benefit from the accented character fix.

However, I now don't have ANY mixable tracks in my library, whereas before I had something like 99% of my library mixable. (With the exception of thise files with accented characters).

I just completed a scan with d_plugins enabled, and I didn't see any output at all that seemed pertinent to MusicMagic.

Any suggestions?

Pierre
2006-10-03, 13:17
Jeff,

What I meant by fix is that I fixed it in my own copy and tested it. I submitted a bug report today describing the problem and offering the developers my modifications as a solution. You will have to give them time to implement.

Sorry for the misleading information.

jeffluckett
2006-10-03, 15:20
Jeff,

What I meant by fix is that I fixed it in my own copy and tested it. I submitted a bug report today describing the problem and offering the developers my modifications as a solution. You will have to give them time to implement.

Sorry for the misleading information.


Fair enough. But that notwithstanding ... shouldn't MusicMagic be working in general (even if it's just the old functionalit) for the current nightly?