Got my Squeezebox (and some FLAC issues...)

[Caleb Epstein]

My squeezebox finally came today. Yay! Setup was a breeze
(802.11b wireless net, 64-bit WEP) and took maybe 2
minutes. Very nicely done, SlimDevices.

I'm now joyfully listening to some FLAC files and have found
a few issues (I am using SlimServer 2003-12-15):

* The log is showing numerous "Undefined string: FLC",
"requested language: EN", and "failsafe language: EN"
messages.

* Elapsed/remaining time display for FLAC files are incorrect.
The elapsed time seems to be counting up in 4-5 second
increments and the remaining time will count down "through"
zero and end up showing double-negative numbers like --9:25.

* Pause (for a minute or so) and then Play of a FLAC stream
resulted in really bad bursts of static for a bit, then things
seemed to sort themselves out after another Pause/Play cycle.
I am using the headphone jack while the family sleeps of the
flu :) I tried thi again just now, and was not able to
reproduce it.

* The sorting logic seems to depend on the fact that files of
different discs are never commingled into one ALBUM. In my
patch earlier today for Slim/Formats/FLAC.pm, I tried to
short-circuited this logic, which causes ALBUM to be adorned
with the (IMHO ugly and unnecessary) " (Disc N of M)". If
this done (by setting the DISC tag but not the SET tag), then
you end up with all of the Track 1's coming before all of the
Track 2's and the files play out-of-order.

I am hunting for the sorting code, but I would like to change
it so that it sorts first by DISC if that is set, then TRACK.

--
Caleb Epstein | bklyn . org | * Espy ponders an uplad queue called 'hell'
cae at | Brooklyn Dust | so I can do dupload --to hell
bklyn dot org | Bunny Mfg. |

[Dan Sully]

* Caleb Epstein <cae (AT) bklyn (DOT) org> shaped the electrons to say...

> My squeezebox finally came today. Yay! Setup was a breeze
> (802.11b wireless net, 64-bit WEP) and took maybe 2
> minutes. Very nicely done, SlimDevices.
>
> I'm now joyfully listening to some FLAC files and have found
> a few issues (I am using SlimServer 2003-12-15):
>
> * The log is showing numerous "Undefined string: FLC",
> "requested language: EN", and "failsafe language: EN"
> messages.
>
> * Elapsed/remaining time display for FLAC files are incorrect.
> The elapsed time seems to be counting up in 4-5 second
> increments and the remaining time will count down "through"
> zero and end up showing double-negative numbers like --9:25.

Caleb - try pulling down the CVS tree, or wait for tonight's build.

I just checked in some FLAC updates today, some of which address your problems.

I'm not sure about the bursty/static problems - Dean or Sean will need to field that.

-D
--
Never ascribe to malice what can be explained by stupidity.

[Caleb Epstein]

On Mon, Dec 15, 2003 at 07:59:03PM -0800, Dan Sully wrote:

> I just checked in some FLAC updates today, some of which address

Seem to improve the situation, but there are 2 spurious
warning messages (I've also installed your Audio/FLAC.pm in my
/usr/local/lib/site_perl which explains the path):

Use of uninitialized value in numeric eq (==) at /usr/local/lib/site_perl/Audio/FLAC.pm line 450.
Can't find vorbis comment metadata block! at /usr/local/lib/site_perl/Audio/FLAC.pm line 79.

A patch below eliminates both warnings.

Index: CPAN/Audio/FLAC.pm
================================================== =================
RCS file: /cvsroot/slim/server/CPAN/Audio/FLAC.pm,v
retrieving revision 1.2
diff -u -b -r1.2 FLAC.pm
--- CPAN/Audio/FLAC.pm 15 Dec 2003 16:39:14 -0000 1.2
+++ CPAN/Audio/FLAC.pm 16 Dec 2003 13:29:18 -0000
@@ -76,7 +76,7 @@
# Parse vorbis tags
$errflag = $self->_parseVorbisComments();
if ($errflag < 0) {
- warn "Can't find vorbis comment metadata block!";
+ # warn "Can't find vorbis comment metadata block!";
close FILE;
undef $self->{'fileHandle'};
return $self;
@@ -433,7 +433,7 @@
my $self = shift;
my $htype = shift;

- my ($idx, $found) = 0;
+ my ($idx, $found) = (0, 0);

# Loop through the metadata_blocks until one of $htype is found
while ($idx < @{$self->{'metadataBlocks'}}) {

--
| | How many surrealists does it take to screw in
Caleb Epstein | bklyn . org | a lightbulb?
cae at | Brooklyn Dust |
bklyn dot org | Bunny Mfg. | One to hold the giraffe and one to fill the
| | bathtub with brightly colored power tools.

[Erik Reckase]

On Tue, Dec 16, 2003 at 08:29:23AM -0500, Caleb Epstein wrote:
>
> On Mon, Dec 15, 2003 at 07:59:03PM -0800, Dan Sully wrote:
>
> > I just checked in some FLAC updates today, some of which address
>
> Seem to improve the situation, but there are 2 spurious
> warning messages (I've also installed your Audio/FLAC.pm in my
> /usr/local/lib/site_perl which explains the path):
>
> Use of uninitialized value in numeric eq (==) at /usr/local/lib/site_perl/Audio/FLAC.pm line 450.
> Can't find vorbis comment metadata block! at /usr/local/lib/site_perl/Audio/FLAC.pm line 79.
>
> A patch below eliminates both warnings.
>
Do you really want to get rid of the second warning? That *does* mean that there's a
missing Vorbis comment metadata block, so doesn't it make sense that the user is
warned in that event? I've never run into a FLAC file without one, as the VENDOR tag
is stored in the comment tag, regardless of the presence of any other tags, IIRC.

If it would be more helpful to have the filename reported with the warning, I'll be
happy to make that modification - but I don't think we should take the warning out.

[Erik Reckase]

> If I recall, the comment block was added in flac 1.1 - if that's the case then
> flac < 1.1 files without the block should not cause an error or warning.
>
> --Jason
>
Ah - I forgot about that. Thanks for straightening me out.

[Caleb Epstein]

On Mon, Dec 15, 2003 at 07:59:03PM -0800, Dan Sully wrote:

> Caleb - try pulling down the CVS tree, or wait for tonight's
> build. > I just checked in some FLAC updates today, some of
> which address your problems.

OK, just had a little more time to look at these. The elapsed
time issue is still there (time counts up in increments of 4-5
seconds and countdown time goes negative).

--
Caleb Epstein | bklyn . org |
cae at | Brooklyn Dust | You will outgrow your usefulness.
bklyn dot org | Bunny Mfg. |