[Slim-Checkins] r4636 - in /trunk/server/Slim:Control/Command.pm Music/Info.pm Player/Client.pm

[Dan Sully]

* Robert Moser shaped the electrons to say...

>Clearing the params shouldn't be needed, the resetClientsToHomeMenu does
>a setMode, which pops off all the modes from the modeStack and
>modeParameterStack. Conversely, having a clearAllParams which doesn't
>touch the modeStack could cause some problems down the line with modes
>barfing because their parameters are all gone.

Ok - I wasn't quite sure - that code is ambiguous and undocumented.

Should I remove that method & call then?

-D
--
<dmercer> Because that is what our industry does.
Churns out useless shit. Followed by inferior re-implementations of useless shit.

[Grotus]

Clearing the params shouldn't be needed, the resetClientsToHomeMenu does
a setMode, which pops off all the modes from the modeStack and
modeParameterStack. Conversely, having a clearAllParams which doesn't
touch the modeStack could cause some problems down the line with modes
barfing because their parameters are all gone.

dsully (AT) svn (DOT) slimdevices.com blurted out:
> Author: dsully
> Date: Sat Oct 15 15:23:16 2005
> New Revision: 4636
>
> URL: http://svn.slimdevices.com?rev=4636&view=rev
> Log:
> Bug: N/A
> Description: Clear out client playlists & stored params when we wipe or rescan. To avoid dangling objects.

[Grotus]

Dan Sully blurted out:
>
> Ok - I wasn't quite sure - that code is ambiguous and undocumented.
>
> Should I remove that method & call then?
>
> -D

yes