PDA

View Full Version : Patch for adding album art to listings



2005-01-21, 17:18
From kdf:

> What would be great would be if this patch can be made to
> work with the 6.0 set of code.

In my 5.4.0 slimserver, I was able to get the "Browse by Artwork" form (browseid3_artwork.html) to be used in all album listings by simply commenting out a few lines of code in Pages.pm. These lines look largely unchanged in version 6.0 of slimserver. Therefore, I think you can get artwork to show up in album listings in the latest 6.0 nightly by commenting out the following lines in Pages.pm.

2438 # if ($params->{'artwork'}) {

2469 # } else {
2470 #
2471 # if (Slim::Utils::Prefs::get('showYear')) {
2472 # $song = $ds->find('track', { 'genre' => $genre,
'artist' => $artist, 'album' => $item });
2473 # $list_form{'year'} = $song->year();
2474 # }
2475 #
2476 # $itemnumber++;
2477 # $params->{'browse_list'} .= ${Slim::Web::HTTP::filltemplatefile
("browseid3_list.html", \%list_form)};
2478 # }

I haven't tested this on 6.0 yet. So I can't promise that it will work.

On 5.4.0, the only problem I have noticed so far is that the alphabar at the bottom of the page is not displayed correctly. I imagine this would not be too hard for someone more familiar with the code to fix.

Taylor

kdf
2005-01-21, 18:14
Quoting trmp3 (AT) hoghill (DOT) net:

> >From kdf:
>
> > What would be great would be if this patch can be made to
> > work with the 6.0 set of code.
>
> In my 5.4.0 slimserver, I was able to get the "Browse by Artwork" form
> (browseid3_artwork.html) to be used in all album listings by simply
> commenting out a few lines of code in Pages.pm. These lines look largely
> unchanged in version 6.0 of slimserver. Therefore, I think you can get
> artwork to show up in album listings in the latest 6.0 nightly by commenting
> out the following lines in Pages.pm.
>
> 2438 # if ($params->{'artwork'}) {
>

Are you certain you have a 6.0 nightly and not the 5.4.1 nightly? These lines
are disabled in 6.0 builds, being as they are now part of a routine called
browseid3_old(). All of the skins in 6.0 should be making use of browsedb().
This new section of Pages.pm is quite a departure from browseid3.
-kdf